Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #8429] Fix trace message loss when traffic is heavy#8430

Merged
lizhimins merged 1 commit intoapache:developapache/rocketmq:developfrom
LetLetMe:developLetLetMe/rocketmq:developCopy head branch name to clipboard
Jul 29, 2024
Merged

[ISSUE #8429] Fix trace message loss when traffic is heavy#8430
lizhimins merged 1 commit intoapache:developapache/rocketmq:developfrom
LetLetMe:developLetLetMe/rocketmq:developCopy head branch name to clipboard

Conversation

@LetLetMe
Copy link
Copy Markdown
Contributor

@LetLetMe LetLetMe commented Jul 23, 2024

Which Issue(s) This PR Fixes

Fixes #8429

Brief Description

当客户端消息生成或者消费tps较高时,轨迹消息batch量会比较大,由于之前没限制batch size,当batch size太大时候会出现轨迹消息丢失

When the TPS (Transactions Per Second) of client message generation or consumption is high, the batch size of trajectory messages can become quite large. Due to the lack of a batch size limit previously, when the batch size becomes too large, there is a probabilistic loss of trajectory messages.

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 24 lines in your changes missing coverage. Please review.

Project coverage is 45.85%. Comparing base (67ddc1d) to head (15052bd).
Report is 62 commits behind head on develop.

Files Patch % Lines
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 70.83% 13 Missing and 8 partials ⚠️
.../java/org/apache/rocketmq/client/ClientConfig.java 50.00% 2 Missing ⚠️
...ocketmq/client/consumer/DefaultMQPushConsumer.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8430      +/-   ##
=============================================
+ Coverage      44.22%   45.85%   +1.62%     
- Complexity     10727    11103     +376     
=============================================
  Files           1274     1274              
  Lines          88939    88987      +48     
  Branches       11432    11441       +9     
=============================================
+ Hits           39330    40801    +1471     
+ Misses         44636    43074    -1562     
- Partials        4973     5112     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java Outdated
Comment thread client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java Outdated
Comment thread client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java Outdated
Comment thread client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java Outdated
@LetLetMe LetLetMe force-pushed the develop branch 7 times, most recently from 118ce0d to 7d18b28 Compare July 25, 2024 08:44
@LetLetMe LetLetMe changed the title [ISSUE #8429] When the client tps is high, trace messages will be lost [ISSUE #8429] Fix trace message loss when traffic is heavy Jul 29, 2024
Comment thread client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java Outdated
@LetLetMe LetLetMe force-pushed the develop branch 4 times, most recently from ec3560f to 7eb0158 Compare July 29, 2024 03:37
lizhimins
lizhimins previously approved these changes Jul 29, 2024
@LetLetMe LetLetMe requested review from drpmma and lollipopjin July 29, 2024 07:52
@lizhimins lizhimins merged commit 217fc8d into apache:develop Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] When the client tps is high, trace messages will be lost

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.