Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #8365] add remoting client non-oneway updateConsumerOffset function#8391

Merged
drpmma merged 3 commits intoapache:developapache/rocketmq:developfrom
qianye1001:add-non-onewayqianye1001/rocketmq:add-non-onewayCopy head branch name to clipboard
Jul 17, 2024
Merged

[ISSUE #8365] add remoting client non-oneway updateConsumerOffset function#8391
drpmma merged 3 commits intoapache:developapache/rocketmq:developfrom
qianye1001:add-non-onewayqianye1001/rocketmq:add-non-onewayCopy head branch name to clipboard

Conversation

@qianye1001
Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes
Enhancement #8365

Brief Description
add remoting client non-oneway updateConsumerOffset function

How Did You Test This Change?
add some new unit test

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 16, 2024

Codecov Report

❌ Patch coverage is 14.28571% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.31%. Comparing base (6f77f05) to head (072bdb1).
⚠️ Report is 568 commits behind head on develop.

Files with missing lines Patch % Lines
...he/rocketmq/proxy/processor/ConsumerProcessor.java 12.50% 14 Missing ⚠️
...q/proxy/service/message/ClusterMessageService.java 0.00% 2 Missing ⚠️
...tmq/proxy/processor/DefaultMessagingProcessor.java 50.00% 1 Missing ⚠️
...tmq/proxy/service/message/LocalMessageService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8391      +/-   ##
=============================================
- Coverage      44.36%   44.31%   -0.05%     
+ Complexity     10782    10769      -13     
=============================================
  Files           1274     1274              
  Lines          88951    88968      +17     
  Branches       11433    11433              
=============================================
- Hits           39463    39427      -36     
- Misses         44535    44577      +42     
- Partials        4953     4964      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma drpmma merged commit 1588d65 into apache:develop Jul 17, 2024
RongtongJin pushed a commit that referenced this pull request Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.