Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #8291] format proxy watermark output#8292

Merged
drpmma merged 1 commit intoapache:developapache/rocketmq:developfrom
zhiliatom:fix_watermarkzhiliatom/rocketmq-zzl:fix_watermarkCopy head branch name to clipboard
Jun 24, 2024
Merged

[ISSUE #8291] format proxy watermark output#8292
drpmma merged 1 commit intoapache:developapache/rocketmq:developfrom
zhiliatom:fix_watermarkzhiliatom/rocketmq-zzl:fix_watermarkCopy head branch name to clipboard

Conversation

@zhiliatom
Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #8291

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.86%. Comparing base (1a73e01) to head (0240947).

Files Patch % Lines
...ache/rocketmq/common/thread/ThreadPoolMonitor.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8292      +/-   ##
=============================================
- Coverage      42.90%   42.86%   -0.05%     
+ Complexity     10408    10399       -9     
=============================================
  Files           1274     1274              
  Lines          88952    88952              
  Branches       11438    11438              
=============================================
- Hits           38168    38126      -42     
- Misses         46076    46114      +38     
- Partials        4708     4712       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma drpmma merged commit b330130 into apache:develop Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] format proxy log watermark output

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.