Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #8166]optimize: make compression type configurable in producer clinet level#8167

Merged
RongtongJin merged 1 commit intoapache:developapache/rocketmq:developfrom
humkum:optimize-compressCopy head branch name to clipboard
May 23, 2024
Merged

[ISSUE #8166]optimize: make compression type configurable in producer clinet level#8167
RongtongJin merged 1 commit intoapache:developapache/rocketmq:developfrom
humkum:optimize-compressCopy head branch name to clipboard

Conversation

@humkum
Copy link
Copy Markdown
Contributor

@humkum humkum commented May 20, 2024

Which Issue(s) This PR Fixes

Fixes #8166

Brief Description

Configure production compression at the producer instance level instead of at the process level.

How Did You Test This Change?

Producer configure the compression type with "ZSTD", and send message who's body over 4KB, debug the compression type producer use is ZSTDCompressor.

image

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 42.89%. Comparing base (0ad0244) to head (98f0162).

Files Patch % Lines
...he/rocketmq/client/producer/DefaultMQProducer.java 54.54% 5 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8167      +/-   ##
=============================================
- Coverage      42.92%   42.89%   -0.03%     
+ Complexity     10372    10368       -4     
=============================================
  Files           1270     1270              
  Lines          88696    88698       +2     
  Branches       11402    11402              
=============================================
- Hits           38072    38050      -22     
- Misses         45922    45943      +21     
- Partials        4702     4705       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humkum humkum requested a review from RongtongJin May 21, 2024 03:58
@RongtongJin RongtongJin merged commit dcc88c6 into apache:develop May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Configure production compression type at the producer instance level instead of at the process level

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.