Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #8145] Optimize some code style in client module#8146

Merged
RongtongJin merged 1 commit intoapache:developapache/rocketmq:developfrom
Willhow-Gao:fix-code-styleWillhow-Gao/rocketmq:fix-code-styleCopy head branch name to clipboard
May 16, 2024
Merged

[ISSUE #8145] Optimize some code style in client module#8146
RongtongJin merged 1 commit intoapache:developapache/rocketmq:developfrom
Willhow-Gao:fix-code-styleWillhow-Gao/rocketmq:fix-code-styleCopy head branch name to clipboard

Conversation

@Willhow-Gao
Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #8145

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 15, 2024

Codecov Report

❌ Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.91%. Comparing base (03b16aa) to head (21fcf9a).
⚠️ Report is 617 commits behind head on develop.

Files with missing lines Patch % Lines
...mq/client/impl/producer/DefaultMQProducerImpl.java 57.14% 2 Missing and 4 partials ⚠️
...rocketmq/client/impl/factory/MQClientInstance.java 66.66% 1 Missing ⚠️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8146      +/-   ##
=============================================
- Coverage      42.93%   42.91%   -0.03%     
+ Complexity     10386    10377       -9     
=============================================
  Files           1270     1270              
  Lines          88693    88689       -4     
  Branches       11401    11402       +1     
=============================================
- Hits           38083    38060      -23     
- Misses         45920    45931      +11     
- Partials        4690     4698       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RongtongJin RongtongJin merged commit 8150e13 into apache:develop May 16, 2024
@Willhow-Gao Willhow-Gao deleted the fix-code-style branch May 27, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize some code style in client module

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.