[ISSUE#8142] Show time of create topic and subScriptionGroup#8143
Merged
RongtongJin merged 3 commits intoapache:developapache/rocketmq:developfrom May 20, 2024
Merged
[ISSUE#8142] Show time of create topic and subScriptionGroup#8143RongtongJin merged 3 commits intoapache:developapache/rocketmq:developfrom
RongtongJin merged 3 commits intoapache:developapache/rocketmq:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8143 +/- ##
=============================================
- Coverage 42.95% 42.85% -0.11%
+ Complexity 10384 10355 -29
=============================================
Files 1270 1270
Lines 88690 88696 +6
Branches 11401 11402 +1
=============================================
- Hits 38097 38010 -87
- Misses 45899 45978 +79
- Partials 4694 4708 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guyinyou
reviewed
May 15, 2024
| response.setRemark(null); | ||
| long endTime = System.currentTimeMillis(); | ||
| long executionTime = endTime - startTime; | ||
| LOGGER.info("" + config.getGroupName() + " is " + executionTime + "ms"); |
humkum
suggested changes
May 15, 2024
| while (iterator.hasNext()) { | ||
| ConsumerFilterData filterData = iterator.next(); | ||
|
|
||
|
|
| long endTime = System.currentTimeMillis(); | ||
| long executionTime = endTime - startTime; | ||
| LOGGER.info("" + config.getGroupName() + " is " + executionTime + "ms"); | ||
| LOGGER.info("" + config.getGroupName() + " is " + executionTime + "ms"); |
RongtongJin
reviewed
May 16, 2024
Comment on lines
+519
to
+521
| long endTime = System.currentTimeMillis(); | ||
| long executionTime = endTime - startTime; | ||
| LOGGER.info("executionTime of create topic:" + topic + " is " + executionTime + "ms"); |
Contributor
There was a problem hiding this comment.
Could you simplify the code？
RongtongJin
approved these changes
May 16, 2024
Contributor
|
ping @humkum Do you have any more suggestions？ |
Willhow-Gao
approved these changes
May 16, 2024
cserwen
approved these changes
May 16, 2024
RongtongJin
pushed a commit
that referenced
this pull request
Jul 19, 2025
* show time of create topic and subScriptionGroup * show time of create topic and subScriptionGroup again * show time of create topic and subScriptionGroup changed --------- Co-authored-by: wengxiaolong <22260113@zju.edu.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execution time of create topic and subscription
Fixes #8142
show time of create topic and subScriptionGroup
add logs of execution time of create topic and subscription