Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #7926] Delete the unnecessary 'else' statement#7920

Merged
RongtongJin merged 1 commit intoapache:developapache/rocketmq:developfrom
oopooa:feat/styleCopy head branch name to clipboard
Mar 15, 2024
Merged

[ISSUE #7926] Delete the unnecessary 'else' statement#7920
RongtongJin merged 1 commit intoapache:developapache/rocketmq:developfrom
oopooa:feat/styleCopy head branch name to clipboard

Conversation

@oopooa
Copy link
Copy Markdown
Contributor

@oopooa oopooa commented Mar 14, 2024

Which Issue(s) This PR Fixes

#7926

Fixes #issue_id

Brief Description

Delete the unnecessary 'else' statement

How Did You Test This Change?

Only code style changed

@RongtongJin
Copy link
Copy Markdown
Contributor

@oopooa It would be better to create an issue associated with the pull request.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 15, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.91%. Comparing base (3c27bfe) to head (cfadca9).
⚠️ Report is 530 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7920      +/-   ##
=============================================
- Coverage      42.92%   42.91%   -0.01%     
+ Complexity      9910     9907       -3     
=============================================
  Files           1190     1190              
  Lines          86042    86042              
  Branches       11081    11081              
=============================================
- Hits           36930    36927       -3     
  Misses         44537    44537              
- Partials        4575     4578       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oopooa
Copy link
Copy Markdown
Contributor Author

oopooa commented Mar 15, 2024

@RongtongJin okay, I have linked an issue to this pull request.

@RongtongJin RongtongJin changed the title Delete the unnecessary 'else' statement [ISSUE #7926] Delete the unnecessary 'else' statement Mar 15, 2024
@RongtongJin RongtongJin merged commit 333c545 into apache:develop Mar 15, 2024
@oopooa oopooa deleted the feat/style branch March 15, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.