Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #7821] Add notifyLast flag for PopLongPollingService#7835

Merged
lollipopjin merged 1 commit intoapache:developapache/rocketmq:developfrom
drpmma:feature/notify-lastdrpmma/rocketmq:feature/notify-lastCopy head branch name to clipboard
Feb 20, 2024
Merged

[ISSUE #7821] Add notifyLast flag for PopLongPollingService#7835
lollipopjin merged 1 commit intoapache:developapache/rocketmq:developfrom
drpmma:feature/notify-lastdrpmma/rocketmq:feature/notify-lastCopy head branch name to clipboard

Conversation

@drpmma
Copy link
Copy Markdown
Contributor

@drpmma drpmma commented Feb 19, 2024

Which Issue(s) This PR Fixes

Fixes #7821

Brief Description

Add notifyLast flag for PopLongPollingService

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 42.95%. Comparing base (d9526e7) to head (01feb54).
Report is 338 commits behind head on develop.

Files with missing lines Patch % Lines
...etmq/broker/longpolling/PopLongPollingService.java 18.18% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7835      +/-   ##
=============================================
- Coverage      43.00%   42.95%   -0.06%     
+ Complexity      9919     9907      -12     
=============================================
  Files           1190     1190              
  Lines          85948    85988      +40     
  Branches       11074    11080       +6     
=============================================
- Hits           36964    36932      -32     
- Misses         44411    44479      +68     
- Partials        4573     4577       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 6f37957 into apache:develop Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Add notifyLast for PopLongPollingService

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.