[ISSUE #7686] The bornTime is not set when using the popMessage API in cluster mode.#7687
Merged
drpmma merged 3 commits intoapache:developapache/rocketmq:developfrom Dec 22, 2023
dingshuangxi888:hotfix/fix_pop_born_timeCopy head branch name to clipboard
Merged
[ISSUE #7686] The bornTime is not set when using the popMessage API in cluster mode.#7687drpmma merged 3 commits intoapache:developapache/rocketmq:developfrom dingshuangxi888:hotfix/fix_pop_born_timeCopy head branch name to clipboard
drpmma merged 3 commits intoapache:developapache/rocketmq:developfrom
dingshuangxi888:hotfix/fix_pop_born_timeCopy head branch name to clipboard
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7687 +/- ##
=============================================
- Coverage 43.15% 43.15% -0.01%
- Complexity 9801 9805 +4
=============================================
Files 1165 1165
Lines 84485 84485
Branches 10969 10969
=============================================
- Hits 36463 36461 -2
- Misses 43491 43501 +10
+ Partials 4531 4523 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cserwen
approved these changes
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7686
Brief Description
The bornTime is not set when using the popMessage API in cluster mode, So it will cause "timeout too much" error. And will never receive any messages.
How Did You Test This Change?
Fix before:
Use gRPC client to receive message by Proxy, you can not receive any messages.
Fix after:
Use gRPC client to receive message by Proxy, you can receive all messages.