Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[ISSUE #7570] fix: add default value for lastPopTimestamp#7571

Merged
RongtongJin merged 1 commit intoapache:developapache/rocketmq:developfrom
HScarb:fix-pop-pushHScarb/rocketmq:fix-pop-pushCopy head branch name to clipboard
Nov 17, 2023
Merged

[ISSUE #7570] fix: add default value for lastPopTimestamp#7571
RongtongJin merged 1 commit intoapache:developapache/rocketmq:developfrom
HScarb:fix-pop-pushHScarb/rocketmq:fix-pop-pushCopy head branch name to clipboard

Conversation

@HScarb
Copy link
Copy Markdown
Contributor

@HScarb HScarb commented Nov 17, 2023

Which Issue(s) This PR Fixes

Fixes #7570

Brief Description

Add default value as current time for lastPopTimestamp.

How Did You Test This Change?

Run PopConsumer, there are no errors in the client log.

2023-11-17 10:26:42.442 INFO  [66096] [NettyClientPublicExecutor_5] [o.a.r.c.i.ClientRemotingProcessor#?:?] - receive broker's notification[x.x.x.x:10931], the consumer group: CID_JODIE_1 changed, rebalance immediately
2023-11-17 10:26:42.475 INFO  [66096] [main] [RocketmqRemoting#?:?] - createChannel: connect remote host[x.x.x.x:10911] success, AbstractBootstrap$PendingRegistrationPromise@bf1ec20(success)
2023-11-17 10:26:42.475 INFO  [66096] [NettyClientWorkerThread_3] [RocketmqRemoting#?:?] - NETTY CLIENT PIPELINE: ACTIVE, x.x.x.x:10911
2023-11-17 10:26:42.475 WARN  [66096] [NettyEventExecutor] [o.a.r.c.i.f.MQClientInstance#?:?] - sendHeartbeatToAllBrokerWithLockV2 lock heartBeat, but failed.
2023-11-17 10:26:42.509 INFO  [66096] [NettyClientPublicExecutor_8] [o.a.r.c.i.ClientRemotingProcessor#?:?] - receive broker's notification[x.x.x.x:10911], the consumer group: CID_JODIE_1 changed, rebalance immediately
2023-11-17 10:26:42.509 INFO  [66096] [main] [o.a.r.c.i.f.MQClientInstance#?:?] - send heart beat to broker[broker-a 0 x.x.x.x:10911] success
2023-11-17 10:26:42.509 INFO  [66096] [main] [o.a.r.c.i.f.MQClientInstance#?:?] - HeartbeatData [clientID=10.173.92.229@66096#2054507404466400, producerDataSet=[ProducerData [groupName=CLIENT_INNER_PRODUCER]], consumerDataSet=[ConsumerData [groupName=CID_JODIE_1, consumeType=CONSUME_PASSIVELY, messageModel=CLUSTERING, consumeFromWhere=CONSUME_FROM_FIRST_OFFSET, unitMode=false, subscriptionDataSet=[SubscriptionData [classFilterMode=false, topic=TopicTest, subString=*, tagsSet=[], codeSet=[], subVersion=1700188001236, expressionType=TAG], SubscriptionData [classFilterMode=false, topic=%RETRY%CID_JODIE_1, subString=*, tagsSet=[], codeSet=[], subVersion=1700188001243, expressionType=TAG]]]]]
2023-11-17 10:26:42.521 INFO  [66096] [RebalanceService] [o.a.r.c.c.s.RemoteBrokerOffsetStore#?:?] - remove unnecessary messageQueue offset. group=CID_JODIE_1, mq=MessageQueue [topic=%RETRY%CID_JODIE_1, brokerName=broker-b, queueId=0], offsetTableSize=0
2023-11-17 10:26:42.562 INFO  [66096] [RebalanceService] [o.a.r.c.i.c.RebalanceImpl#?:?] - doRebalance, CID_JODIE_1, add a new mq, MessageQueue [topic=%RETRY%CID_JODIE_1, brokerName=broker-b, queueId=0]
2023-11-17 10:26:42.563 INFO  [66096] [RebalanceService] [o.a.r.c.c.s.RemoteBrokerOffsetStore#?:?] - remove unnecessary messageQueue offset. group=CID_JODIE_1, mq=MessageQueue [topic=%RETRY%CID_JODIE_1, brokerName=broker-a, queueId=0], offsetTableSize=1
2023-11-17 10:26:42.598 INFO  [66096] [RebalanceService] [o.a.r.c.i.c.RebalanceImpl#?:?] - doRebalance, CID_JODIE_1, add a new mq, MessageQueue [topic=%RETRY%CID_JODIE_1, brokerName=broker-a, queueId=0]
2023-11-17 10:26:42.599 INFO  [66096] [RebalanceService] [o.a.r.c.i.c.RebalanceImpl#?:?] - broker rebalanced result changed. allocateMessageQueueStrategyName=AVG, group=CID_JODIE_1, topic=%RETRY%CID_JODIE_1, clientId=10.173.92.229@66096#2054507404466400, assignmentSet=[MessageQueueAssignment [MessageQueue=MessageQueue [topic=%RETRY%CID_JODIE_1, brokerName=broker-a, queueId=0], Mode=PULL], MessageQueueAssignment [MessageQueue=MessageQueue [topic=%RETRY%CID_JODIE_1, brokerName=broker-b, queueId=0], Mode=PULL]]
2023-11-17 10:26:42.599 INFO  [66096] [RebalanceService] [o.a.r.c.i.c.RebalanceImpl#?:?] - %RETRY%CID_JODIE_1 Rebalance changed, also update version: 1700188001243, 1700188002599
2023-11-17 10:26:42.741 INFO  [66096] [RebalanceService] [o.a.r.c.i.c.RebalanceImpl#?:?] - doRebalance, CID_JODIE_1, add a new pop mq, MessageQueue [topic=TopicTest, brokerName=broker-a, queueId=-1]
2023-11-17 10:26:42.742 INFO  [66096] [RebalanceService] [o.a.r.c.i.c.RebalanceImpl#?:?] - doRebalance, CID_JODIE_1, add a new pop mq, MessageQueue [topic=TopicTest, brokerName=broker-b, queueId=-1]
2023-11-17 10:26:42.742 INFO  [66096] [RebalanceService] [o.a.r.c.i.c.RebalanceImpl#?:?] - broker rebalanced result changed. allocateMessageQueueStrategyName=AVG, group=CID_JODIE_1, topic=TopicTest, clientId=10.173.92.229@66096#2054507404466400, assignmentSet=[MessageQueueAssignment [MessageQueue=MessageQueue [topic=TopicTest, brokerName=broker-a, queueId=-1], Mode=POP], MessageQueueAssignment [MessageQueue=MessageQueue [topic=TopicTest, brokerName=broker-b, queueId=-1], Mode=POP]]
2023-11-17 10:26:42.742 INFO  [66096] [RebalanceService] [o.a.r.c.i.c.RebalanceImpl#?:?] - TopicTest Rebalance changed, also update version: 1700188001236, 1700188002742

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 17, 2023 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 43.09%. Comparing base (651a5ca) to head (71debe6).
⚠️ Report is 578 commits behind head on develop.

Files with missing lines Patch % Lines
...rocketmq/client/impl/consumer/PopProcessQueue.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #7571      +/-   ##
=============================================
- Coverage      43.15%   43.09%   -0.06%     
+ Complexity      9712     9705       -7     
=============================================
  Files           1159     1159              
  Lines          84040    84041       +1     
  Branches       10923    10923              
=============================================
- Hits           36266    36219      -47     
- Misses         43262    43302      +40     
- Partials        4512     4520       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RongtongJin RongtongJin merged commit 01a2aef into apache:develop Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RongtongJin RongtongJin RongtongJin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] PopProcessQueue's lastPopTimestamp defaults to 0, resulting in rebalance failed

3 participants

@HScarb @codecov-commenter @RongtongJin
Morty Proxy This is a proxified and sanitized view of the page, visit original site.