Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #7489] Code comment enhancement in example#7490

Merged
RongtongJin merged 7 commits intoapache:developapache/rocketmq:developfrom
joeCarf:fix_7489joeCarf/rocketmq:fix_7489Copy head branch name to clipboard
Oct 23, 2023
Merged

[ISSUE #7489] Code comment enhancement in example#7490
RongtongJin merged 7 commits intoapache:developapache/rocketmq:developfrom
joeCarf:fix_7489joeCarf/rocketmq:fix_7489Copy head branch name to clipboard

Conversation

@joeCarf
Copy link
Copy Markdown
Contributor

@joeCarf joeCarf commented Oct 23, 2023

Which Issue(s) This PR Fixes

Fixes #7489

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #7490 (d9cf5e7) into develop (f0f15b5) will increase coverage by 0.01%.
Report is 2 commits behind head on develop.
The diff coverage is 80.00%.

@@              Coverage Diff              @@
##             develop    #7490      +/-   ##
=============================================
+ Coverage      42.93%   42.94%   +0.01%     
- Complexity      9660     9670      +10     
=============================================
  Files           1161     1161              
  Lines          83930    83933       +3     
  Branches       10898    10898              
=============================================
+ Hits           36038    36049      +11     
+ Misses         43410    43407       -3     
+ Partials        4482     4477       -5     
Files Coverage Δ
...tmq/proxy/service/message/LocalMessageService.java 60.81% <100.00%> (ø)
...mq/proxy/service/message/LocalRemotingCommand.java 88.88% <100.00%> (+1.38%) ⬆️
...che/rocketmq/acl/plain/PlainPermissionManager.java 78.37% <0.00%> (ø)
...pache/rocketmq/remoting/protocol/LanguageCode.java 87.50% <50.00%> (-3.41%) ⬇️

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joeCarf
Copy link
Copy Markdown
Contributor Author

joeCarf commented Oct 23, 2023

@RongtongJin hi~ PTAL

@RongtongJin RongtongJin merged commit 8f020b3 into apache:develop Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code comments of updateConsumeOffset() should be corrected

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.