Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #7330] Add goaway and reconnection mechanism#7331

Merged
drpmma merged 8 commits intoapache:developapache/rocketmq:developfrom
drpmma:feature/go-away-sub-taskdrpmma/rocketmq:feature/go-away-sub-taskCopy head branch name to clipboard
Oct 10, 2023
Merged

[ISSUE #7330] Add goaway and reconnection mechanism#7331
drpmma merged 8 commits intoapache:developapache/rocketmq:developfrom
drpmma:feature/go-away-sub-taskdrpmma/rocketmq:feature/go-away-sub-taskCopy head branch name to clipboard

Conversation

@drpmma
Copy link
Copy Markdown
Contributor

@drpmma drpmma commented Sep 8, 2023

Which Issue(s) This PR Fixes

Fixes #7330

Brief Description

Add goaway response code when the server is shutting down and client reconnection and transparent retry mechanism.

How Did You Test This Change?

Existing unit test.

@drpmma drpmma added the Draft label Sep 8, 2023
@drpmma drpmma force-pushed the feature/go-away-sub-task branch from 48e5d18 to b33c915 Compare September 8, 2023 08:49
@drpmma drpmma force-pushed the feature/go-away-sub-task branch from f26c8d5 to 2f5a95c Compare October 8, 2023 09:51
@drpmma drpmma removed the Draft label Oct 9, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 9, 2023

Codecov Report

Attention: Patch coverage is 30.90909% with 76 lines in your changes missing coverage. Please review.

Project coverage is 42.67%. Comparing base (8415608) to head (9cde118).
Report is 559 commits behind head on develop.

Files with missing lines Patch % Lines
...e/rocketmq/remoting/netty/NettyRemotingClient.java 32.50% 47 Missing and 7 partials ⚠️
...che/rocketmq/remoting/netty/NettyClientConfig.java 25.00% 9 Missing ⚠️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 14.28% 5 Missing and 1 partial ⚠️
...che/rocketmq/remoting/netty/NettyServerConfig.java 37.50% 5 Missing ⚠️
...e/rocketmq/remoting/netty/NettyRemotingServer.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7331      +/-   ##
=============================================
- Coverage      42.70%   42.67%   -0.03%     
+ Complexity      9480     9478       -2     
=============================================
  Files           1150     1150              
  Lines          82687    82814     +127     
  Branches       10749    10768      +19     
=============================================
+ Hits           35311    35344      +33     
- Misses         42973    43050      +77     
- Partials        4403     4420      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

RongtongJin
RongtongJin previously approved these changes Oct 10, 2023
…rLifecycleListener (apache#7432)

* Fix flaky test of DLedgerControllerTest#testBrokerLifecycleListener
@drpmma drpmma merged commit 4acb43e into apache:develop Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] [ISSUE #7296] [TASK 3] Add goaway and reconnection mechanism

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.