Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #7199] grpcClientChannel header add null judgement#7238

Merged
Oliverwqcwrw merged 6 commits intoapache:developapache/rocketmq:developfrom
weihubeats:weihubeats/bugfix_grpcClient_nullweihubeats/rocketmq:weihubeats/bugfix_grpcClient_nullCopy head branch name to clipboard
Nov 28, 2024
Merged

[ISSUE #7199] grpcClientChannel header add null judgement#7238
Oliverwqcwrw merged 6 commits intoapache:developapache/rocketmq:developfrom
weihubeats:weihubeats/bugfix_grpcClient_nullweihubeats/rocketmq:weihubeats/bugfix_grpcClient_nullCopy head branch name to clipboard

Conversation

@weihubeats
Copy link
Copy Markdown
Member

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 23, 2023

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.94%. Comparing base (82b2f8e) to head (dae83ec).
Report is 547 commits behind head on develop.

Files with missing lines Patch % Lines
...ketmq/proxy/grpc/v2/channel/GrpcClientChannel.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7238      +/-   ##
=============================================
- Coverage      42.97%   42.94%   -0.03%     
+ Complexity      9670     9661       -9     
=============================================
  Files           1161     1161              
  Lines          83926    83926              
  Branches       10898    10898              
=============================================
- Hits           36069    36045      -24     
- Misses         43380    43403      +23     
- Partials        4477     4478       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@weihubeats
Copy link
Copy Markdown
Member Author

@Oliverwqcwrw Can you look at this pr?

Copy link
Copy Markdown
Member

@Oliverwqcwrw Oliverwqcwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I don't think the header should be null in theory, it is necessary for the robustness of the code to add this null judgment.

@weihubeats
Copy link
Copy Markdown
Member Author

@RongtongJin Can you help merge this pr

@weihubeats
Copy link
Copy Markdown
Member Author

@Oliverwqcwrw Can you help merge this pr

@weihubeats
Copy link
Copy Markdown
Member Author

@RongtongJin Can you help merge this pr

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

@github-actions github-actions Bot added the stale label Nov 28, 2024
@weihubeats
Copy link
Copy Markdown
Member Author

@Oliverwqcwrw Can you look at this pr?

@Oliverwqcwrw Oliverwqcwrw merged commit d2c436b into apache:develop Nov 28, 2024
@Oliverwqcwrw
Copy link
Copy Markdown
Member

@Oliverwqcwrw Can you look at this pr?

Thanks for your contribution

RongtongJin pushed a commit that referenced this pull request Jul 19, 2025
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.