Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #6933] Optimize delete topic in tiered storage#6973

Merged
lizhimins merged 2 commits intoapache:developapache/rocketmq:developfrom
lizhimins:optimize-deletelizhimins/rocketmq:optimize-deleteCopy head branch name to clipboard
Jun 30, 2023
Merged

[ISSUE #6933] Optimize delete topic in tiered storage#6973
lizhimins merged 2 commits intoapache:developapache/rocketmq:developfrom
lizhimins:optimize-deletelizhimins/rocketmq:optimize-deleteCopy head branch name to clipboard

Conversation

@lizhimins
Copy link
Copy Markdown
Member

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 30, 2023

Codecov Report

❌ Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.68%. Comparing base (87075c2) to head (f4dfcfc).
⚠️ Report is 918 commits behind head on develop.

Files with missing lines Patch % Lines
...pache/rocketmq/tieredstore/TieredMessageStore.java 66.66% 3 Missing and 1 partial ⚠️
...cketmq/tieredstore/file/TieredFlatFileManager.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6973      +/-   ##
=============================================
- Coverage      42.69%   42.68%   -0.02%     
- Complexity      9221     9225       +4     
=============================================
  Files           1131     1131              
  Lines          80485    80482       -3     
  Branches       10520    10515       -5     
=============================================
- Hits           34366    34350      -16     
- Misses         41822    41834      +12     
- Partials        4297     4298       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit 79967c0 into apache:develop Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.