Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #6742]Support daily build tests#6744

Merged
lizhimins merged 18 commits intoapache:developapache/rocketmq:developfrom
cryptoya:cicdcryptoya/rocketmq:cicdCopy head branch name to clipboard
Jul 3, 2023
Merged

[ISSUE #6742]Support daily build tests#6744
lizhimins merged 18 commits intoapache:developapache/rocketmq:developfrom
cryptoya:cicdcryptoya/rocketmq:cicdCopy head branch name to clipboard

Conversation

@cryptoya
Copy link
Copy Markdown
Contributor

@cryptoya cryptoya commented May 12, 2023

Which Issue(s) This PR Fixes

Fixes #6742

Brief Description

  • Add a e2e test in workflow, when run test failure, the SNAPSHOT package will not deploy to repository
  • Changed maxUniqueSnapshots settings for Maven in order to go back over the last 2 months of build history
  • Changed the SNAPSHOT version name of the develop branch build to prevent package overwriting that might result from other branch builds

How Did You Test This Change?

image
image

The last step requires you to upload the package using the apache repository permissions

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 12, 2023

Codecov Report

Merging #6744 (22f3aac) into develop (aaa4a4b) will increase coverage by 0.09%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #6744      +/-   ##
=============================================
+ Coverage      42.64%   42.74%   +0.09%     
- Complexity      9106     9160      +54     
=============================================
  Files           1127     1128       +1     
  Lines          79942    80129     +187     
  Branches       10392    10432      +40     
=============================================
+ Hits           34094    34248     +154     
- Misses         41572    41602      +30     
- Partials        4276     4279       +3     

see 55 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@tsunghanjacktsai tsunghanjacktsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Guess we could try if it could work.

Copy link
Copy Markdown
Member

@lizhimins lizhimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File should add licensed to the ASF

@aaron-ai
Copy link
Copy Markdown
Member

How can GitHub Action's daily builds help us identify which commit introduced the issue?

Comment thread .github/workflows/snapshot-automation.yml
Comment thread .github/workflows/snapshot-automation.yml
caigy
caigy previously requested changes May 24, 2023
Comment thread .github/workflows/snapshot-automation.yml Outdated
@cryptoya cryptoya requested review from aaron-ai and lizhimins June 5, 2023 11:58
Copy link
Copy Markdown
Member

@aaron-ai aaron-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, Thanks @cryptoya !

aaron-ai
aaron-ai previously approved these changes Jun 14, 2023
@lizhimins lizhimins dismissed caigy’s stale review July 3, 2023 06:54

already resolved

@lizhimins lizhimins merged commit 5c3bd98 into apache:develop Jul 3, 2023
lizhimins pushed a commit to lizhimins/rocketmq that referenced this pull request Jul 26, 2023
* Update to support "Snapshot Release" daily test
* Modify 'snapshot-automation.yml'
* Add Apache header
* Supports manual triggering through branch and commitId
* Remove the proxy in servers of github actions.
* Update docker repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Support daily build tests

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.