Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ISSUE #10019] Revert "[ISSUE #8127]Optimize the metric calculation logic of the time wheel"#10020

Merged
ShannonDing merged 3 commits intoapache:developapache/rocketmq:developfrom
RongtongJin:develop-0117RongtongJin/rocketmq:develop-0117Copy head branch name to clipboard
Jan 21, 2026
Merged

[ISSUE #10019] Revert "[ISSUE #8127]Optimize the metric calculation logic of the time wheel"#10020
ShannonDing merged 3 commits intoapache:developapache/rocketmq:developfrom
RongtongJin:develop-0117RongtongJin/rocketmq:develop-0117Copy head branch name to clipboard

Conversation

@RongtongJin
Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #10019

Brief Description

Revert "[ISSUE #8127]Optimize the metric calculation logic of the time wheel"
#8128

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.89%. Comparing base (ee10411) to head (307fce1).

Files with missing lines Patch % Lines
...apache/rocketmq/store/timer/TimerMessageStore.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10020      +/-   ##
=============================================
- Coverage      49.02%   48.89%   -0.14%     
+ Complexity     13364    13328      -36     
=============================================
  Files           1373     1373              
  Lines          99682    99671      -11     
  Branches       12884    12880       -4     
=============================================
- Hits           48874    48734     -140     
- Misses         44910    45018     +108     
- Partials        5898     5919      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@GenerousMan GenerousMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ni-ze
Copy link
Copy Markdown
Contributor

ni-ze commented Jan 20, 2026

LGTM

@ni-ze ni-ze requested review from GenerousMan and removed request for GenerousMan January 20, 2026 09:24
@ShannonDing ShannonDing merged commit 4aa6cdd into apache:develop Jan 21, 2026
11 of 13 checks passed
dingshuangxi888 pushed a commit to dingshuangxi888/rocketmq that referenced this pull request Feb 10, 2026
…alculation logic of the time wheel" (apache#10020)

* Revert "[ISSUE apache#8127]Optimize the metric calculation logic of the time wheel"

* Revert "[ISSUE apache#8127]Optimize the metric calculation logic of the time wheel"

* Revert "[ISSUE apache#8127]Optimize the metric calculation logic of the time wheel"

---------

Co-authored-by: RongtongJin <user@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] When timer messages are deleted, the metrics become inaccurate

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.