Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Bug] should dataReadAheadEnable default be true? #6940

Copy link
Copy link
@yuz10

Description

@yuz10
Issue body actions

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Ubuntu 20.04

RocketMQ version

5.1.3

JDK Version

1.8

Describe the Bug

Before #6336 [RIP-62] Cold Read Control, the default value of madvice is MADV_NORMAL. after RIP-62, the default value changes to MADV_RANDOM. so I think the default value of dataReadAheadEnable should be true, to keep the same with old RocketMQ versions.

Steps to Reproduce

start new version of RocketMQ.

What Did You Expect to See?

madvice MADV_RANDOM is not called.

What Did You See Instead?

madvice MADV_RANDOM is called.

Additional Context

https://github.com/apache/rocketmq/blob/develop/store/src/main/java/org/apache/rocketmq/store/CommitLog.java#L149

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.