Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 pyiceberg/io/pyarrow.py
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ def visit_uuid(self, _: UUIDType) -> pa.DataType:
return pa.binary(16)

def visit_binary(self, _: BinaryType) -> pa.DataType:
return pa.large_binary()
return pa.binary()


def _convert_scalar(value: Any, iceberg_type: IcebergType) -> pa.scalar:
Expand Down
2 changes: 1 addition & 1 deletion 2 tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -2131,7 +2131,7 @@ def pa_schema() -> "pa.Schema":
# ("time", pa.time64("us")),
# Not natively supported by Arrow
# ("uuid", pa.fixed(16)),
("binary", pa.large_binary()),
("binary", pa.binary()),
("fixed", pa.binary(16)),
])

Expand Down
2 changes: 1 addition & 1 deletion 2 tests/io/test_pyarrow.py
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ def test_string_type_to_pyarrow() -> None:

def test_binary_type_to_pyarrow() -> None:
iceberg_type = BinaryType()
assert visit(iceberg_type, _ConvertToArrowSchema()) == pa.large_binary()
assert visit(iceberg_type, _ConvertToArrowSchema()) == pa.binary()


def test_struct_type_to_pyarrow(table_schema_simple: Schema) -> None:
Expand Down
2 changes: 1 addition & 1 deletion 2 tests/io/test_pyarrow_visitor.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def test_pyarrow_string_to_iceberg() -> None:


def test_pyarrow_variable_binary_to_iceberg() -> None:
pyarrow_type = pa.large_binary()
pyarrow_type = pa.binary()
converted_iceberg_type = visit_pyarrow(pyarrow_type, _ConvertToIceberg())
assert converted_iceberg_type == BinaryType()
assert visit(converted_iceberg_type, _ConvertToArrowSchema()) == pyarrow_type
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.