UUID literal to binary and fixed #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Fokko this is ready for your review whenever you have a chance, thanks! |
Fokko
approved these changes
Mar 18, 2024
Contributor
Fokko
left a comment
There was a problem hiding this comment.
This looks great, thanks for creating this PR @sebpretzer
HonahX
pushed a commit
to HonahX/iceberg-python
that referenced
this pull request
Apr 13, 2024
* poetry lock --no-update * adding uuid literal to fixed/binary type * simplifying uuid generation * editted wrong line of test * adding assert_type for uuid literal * assertation doesn't add much * mypy no longer failing * old code got into PR...oops * cleaning up empty lines
Fokko
pushed a commit
that referenced
this pull request
Apr 14, 2024
* poetry lock --no-update * adding uuid literal to fixed/binary type * simplifying uuid generation * editted wrong line of test * adding assert_type for uuid literal * assertation doesn't add much * mypy no longer failing * old code got into PR...oops * cleaning up empty lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #522
Note:
asserts isinstance(...passes the tests but fails mypy. I didn't want to dig too far into this issue since I believe its unrelated. Not sure if that should be worked on separately, or I am misunderstanding something and this isn't actually an issue. Errors look like:Subclass of "Literal[UUID]" and "BinaryLiteral" cannot exist: would have inconsistent method resolution order [unreachable]