Cleanup conftest, remove LocalOutputFile #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HonahX
approved these changes
Feb 26, 2024
Contributor
HonahX
left a comment
There was a problem hiding this comment.
Thanks for the fix @kevinjqliu! CI seems to fail due to a small linter issue.
Contributor
Author
|
thanks@HonahX, I just ran |
himadripal
pushed a commit
to himadripal/iceberg-python
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While browsing
conftest.py, I noticedLocalOutputFilewhich is not used anywhere in the repo.It's first introduced in this commit, originally used for
LocalFileIO.Since we added the ability to write to local filesystem in #301, I believe this is no longer needed