Change Append/Overwrite API to accept snapshot properties #419
Conversation
Fokko
left a comment
There was a problem hiding this comment.
Thanks @Gowthami03B for picking this up. This looks great, just a suggestion about the API itself. I can see that we want to add more keyword-arguments later on, and catching everything as table properties makes it harder to evolve this later on as it might conflict with a future keyword arguments.
Also, could you add this both to the docstring of .append(..) and .overwrite(..) and also document this under mkdocs/docs/api.md? Thanks again! 🙌
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Fokko
left a comment
There was a problem hiding this comment.
This looks great, thanks for working on this @Gowthami03B
I have one small suggestion. In the future, we want to run the Python code in the example blocks to make sure that everything works. Therefore it is best to make sure that it is valid Python.
Co-authored-by: Fokko Driesprong <fokko@apache.org>
|
@Gowthami03B Now the release is out, we can merge this. Could you fix the merge conflicts? Thanks! |
@Fokko Done! |
Fokko
left a comment
There was a problem hiding this comment.
This looks good @Gowthami03B I have one small suggestion, but apart from that it looks good to go 🚀
Co-authored-by: Fokko Driesprong <fokko@apache.org>
|
Thanks @Gowthami03B for adding this 🙌 |
No description provided.