Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented Feb 1, 2024

No description provided.

Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Fokko! Just have 2 small question.

pyiceberg/schema.py Show resolved Hide resolved
pyiceberg/table/__init__.py Show resolved Hide resolved
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is good to go when CI pass. Thanks!

pyiceberg/table/__init__.py Outdated Show resolved Hide resolved
pyiceberg/table/__init__.py Outdated Show resolved Hide resolved
Fokko and others added 2 commits February 5, 2024 20:50
Co-authored-by: Honah J. <undefined.newdb.newtable@gmail.com>
Co-authored-by: Honah J. <undefined.newdb.newtable@gmail.com>
@Fokko
Copy link
Contributor Author

Fokko commented Feb 5, 2024

@HonahX Thanks 🙏

@Fokko Fokko added this to the PyIceberg 0.7.0 release milestone Feb 7, 2024
@Fokko Fokko merged commit 339ba53 into apache:main Feb 25, 2024
@Fokko Fokko deleted the fd-nice-error branch February 25, 2024 22:33
himadripal pushed a commit to himadripal/iceberg-python that referenced this pull request Mar 1, 2024
* Nice error

* Simplify a bit

* Property

Co-authored-by: Honah J. <undefined.newdb.newtable@gmail.com>

* Property

Co-authored-by: Honah J. <undefined.newdb.newtable@gmail.com>

* Whitespace

---------

Co-authored-by: Honah J. <undefined.newdb.newtable@gmail.com>
HonahX pushed a commit to HonahX/iceberg-python that referenced this pull request Mar 29, 2024
HonahX added a commit that referenced this pull request Mar 31, 2024
Backport to 0.6.1

Co-authored-by: Fokko Driesprong <fokko@tabular.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.