Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Inject columns of proper length for missing fields #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevinjqliu merged 1 commit into from
Mar 5, 2025
Merged

Inject columns of proper length for missing fields #1767

kevinjqliu merged 1 commit into from
Mar 5, 2025

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Mar 5, 2025

Fixes #1766.

Fokko
Fokko approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @lidavidm Thanks for fixing this 🙌

@lidavidm
Copy link
Member Author

lidavidm commented Mar 5, 2025

BTW one thing I noticed: the tests compare repr or str of PyArrow objects, however, we don't guarantee that is stable so the tests may break - it would be better to compare objects directly if possible

kevinjqliu
kevinjqliu approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good catch!

@kevinjqliu
Copy link
Contributor

kevinjqliu commented Mar 5, 2025

BTW one thing I noticed: the tests compare repr or str of PyArrow objects, however, we don't guarantee that is stable so the tests may break - it would be better to compare objects directly if possible

I see we fixed it for test_identity_transform_column_projection. There are a couple more tests with that issue in the same file. Its a good idea to compare the table value and not the repr

@kevinjqliu kevinjqliu merged commit ace87ed into apache:main Mar 5, 2025
7 checks passed
@lidavidm lidavidm deleted the gh-1766 branch March 5, 2025 23:55
@Fokko Fokko added this to the PyIceberg 0.9.1 milestone Apr 20, 2025
Fokko pushed a commit that referenced this pull request Apr 25, 2025
@lidavidm @Fokko
Inject columns of proper length for missing fields (#1767)
798610a 
Fixes #1766.
gabeiglio pushed a commit to Netflix/iceberg-python that referenced this pull request Aug 13, 2025
@lidavidm @gabeiglio
Inject columns of proper length for missing fields (apache#1767)
ab9c44b 
Fixes apache#1766.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fokko Fokko Fokko approved these changes

@kevinjqliu kevinjqliu kevinjqliu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

PyIceberg 0.9.1

Development

Successfully merging this pull request may close these issues.

Column projection: filling in default values is broken for tables that don't have exactly 1 row

3 participants

@lidavidm @kevinjqliu @Fokko
Morty Proxy This is a proxified and sanitized view of the page, visit original site.