Accept date in literal #1618
Merged
Accept date in literal #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Feb 6, 2025
kevinjqliu
reviewed
Feb 6, 2025
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks like theres a CI issue, Fokko's suggestion might help resolve it.
Could you also add a test for this change? heres an example for TimestampLiteral
iceberg-python/tests/expressions/test_literals.py
Lines 909 to 910 in dfbee4b
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Contributor
|
@TennyZhuang Can you run |
kevinjqliu
approved these changes
Feb 7, 2025
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
aside from the lint issue, LGTM!
Contributor
Author
|
I have no idea why the CI failed again. |
Contributor
|
@TennyZhuang That looks unrelated to your PR, I've restarted the job |
Contributor
|
Thanks @TennyZhuang for adding this, and thanks @kevinjqliu for the review 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.