dont override global warning #1350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Expecting this to surface the issue with pyspark using |
Fokko
approved these changes
Nov 20, 2024
Contributor
Fokko
left a comment
There was a problem hiding this comment.
Good catch! I like the context manager, thanks for fixing this!
This was referenced Nov 25, 2024
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* dont override global * add back warning filter
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* dont override global * add back warning filter
JE-Chen
pushed a commit
to JE-Chen/iceberg-python
that referenced
this pull request
Dec 23, 2024
* dont override global * add back warning filter
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 24, 2024
* dont override global * add back warning filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking into #1346, I was confused by why the
datetime.datetime.utcfromtimestampwarning only errored for the branch and not for themainbranch.Turns out there's a bug in the
_deprecation_warningcode where all warnings are suppressed when displaying a deprecation warning. Thedatetime.datetime.utcfromtimestampwarning is suppressed in themainbranch because the test also triggered other deprecation warnings. When those deprecation warnings are removed in the feature branch, the only other warning is shown and causes the test to fail.This PR changes
_deprecation_warningto temporarily override warning handling.