Allow union of {int,long}, {float,double}, etc
#1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
reviewed
Nov 1, 2024
tests/test_schema.py
Outdated
| assert isinstance(applied.fields[0].field_type, DoubleType) | ||
|
|
||
|
|
||
| def test_promote_long_to_int() -> None: |
Contributor
There was a problem hiding this comment.
nit, I dont see a test case for int to long. Can we add that here?
Theres a corresponding test case for double to float and float to double
Contributor
Author
There was a problem hiding this comment.
Good one, added those as well 👍
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
…o fd-extend-union
kevinjqliu
approved these changes
Nov 4, 2024
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! A few nit comments
Contributor
Author
|
Thanks for the review @kevinjqliu 🙌 |
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Allow union of `{int,long}`, `{float,double}`, etc
* Thanks Kevin!
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
* Thanks Kevin!
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
* MOAR tests
* lint
* Make the tests happy
* Remove redundant test
---------
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Allow union of `{int,long}`, `{float,double}`, etc
* Thanks Kevin!
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
* Thanks Kevin!
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
* MOAR tests
* lint
* Make the tests happy
* Remove redundant test
---------
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.