Remove numpy as a hard dependency #1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Arrow 18.0.0 numpy is not a dependency anymore: apache/arrow#44148 I think it would be good to also remove it from PyIceberg
kevinjqliu
reviewed
Oct 30, 2024
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks for the PR, LGTM!
I've opened #1271 for tracking the performance regression and backporting the pyarrow range function when it becomes available. Do you mind adding it as a comment to the function?
Fokko
commented
Oct 30, 2024
Contributor
Author
|
@kevinjqliu That's an excellent suggestion, I only created one on the Arrow side, thanks! |
|
@kevinjqliu curious what y'all think of my comment here: #1259 (comment) |
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Remove numpy as a hard dependency With Arrow 18.0.0 numpy is not a dependency anymore: apache/arrow#44148 I think it would be good to also remove it from PyIceberg * Add link to issue
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Remove numpy as a hard dependency With Arrow 18.0.0 numpy is not a dependency anymore: apache/arrow#44148 I think it would be good to also remove it from PyIceberg * Add link to issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Arrow 18.0.0 numpy is not a dependency anymore: apache/arrow#44148
I think it would be good to remove it from PyIceberg.
Closes #1259
Closes #1198