Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented Sep 10, 2024

Fixes #1108

Copy link
Collaborator

@sungwy sungwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fokko ! It's great to see you again. Thank you for jumping in to fix this issue. The fix and the test looks good to me, I just have a nit suggestion about the name of the new test

tests/integration/test_writes/test_writes.py Outdated Show resolved Hide resolved
@sungwy sungwy merged commit 67e8773 into apache:main Sep 11, 2024
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
* Use the correct spec when rewiting existing manifests

Fixes apache#1108

* Rename test
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
* Use the correct spec when rewiting existing manifests

Fixes apache#1108

* Rename test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue when overwriting data with row filter

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.