Bug Fix: Glue and Hive catalog return only Iceberg tables #1145
Conversation
cbe2ff6 to
cfb1d45
Compare
sungwy
left a comment
There was a problem hiding this comment.
Hi @mark-major thank you for putting together this PR. The tests for the hive and glue catalogs seem to prove that your implementation is working 💯
I've left a question about the dynamodb implementation, and a nit suggestion, please let me know your thoughts!
|
|
||
| def list_tables(self, namespace: Union[str, Identifier]) -> List[Identifier]: | ||
| """List tables under the given namespace in the catalog (including non-Iceberg tables). | ||
| """List Iceberg tables under the given namespace in the catalog. |
There was a problem hiding this comment.
I noticed that we only updated the docstring here, without a change in the code.
Does Dynamodb already only return Iceberg tables?
There was a problem hiding this comment.
It was quite a long time since I have worked on this, but if I recall correctly then yes, DynamoDB returned only Iceberg tables.
Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
sungwy
left a comment
There was a problem hiding this comment.
Thank you again for working on this @mark-major ! I've confirmed that this behavior is consistent with Java
* glue and hive returns iceberg tables * fix formatting * Update pyiceberg/catalog/glue.py Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com> --------- Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
* glue and hive returns iceberg tables * fix formatting * Update pyiceberg/catalog/glue.py Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com> --------- Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
Closes #314
Glue and Hive catalogs
list_tables()method filters for Iceberg tables.