fix (issue-1079): allow update_column to set doc as '' #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
107e5a8 to
2e140b9
Compare
TiansuYu
commented
Aug 22, 2024
pyiceberg/table/__init__.py
Outdated
| doc=doc or updated.doc, | ||
| required=updated.required, | ||
| doc=doc if doc is not None else updated.doc, | ||
| required=required or updated.required, |
Contributor
Author
There was a problem hiding this comment.
@sungwy I have fixed this as well. let me know if this ignorance is intended in the first place.
sungwy
reviewed
Aug 22, 2024
pyiceberg/table/__init__.py
Outdated
| doc=doc or updated.doc, | ||
| required=updated.required, | ||
| doc=doc if doc is not None else updated.doc, | ||
| required=required or updated.required, |
Collaborator
There was a problem hiding this comment.
😱
This looks correct to me. Thank you for the fix!
sungwy
reviewed
Aug 24, 2024
sungwy
reviewed
Aug 24, 2024
Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
sungwy
approved these changes
Aug 24, 2024
sungwy
reviewed
Aug 26, 2024
Collaborator
sungwy
left a comment
There was a problem hiding this comment.
I will remove these comments now as well, as they make less sense without the proposed change to required field update
sungwy
added a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* fix (issue-1079): allow update_column to set doc as '' * fix (issue-1079): add test for required and fix version * Apply suggestions from code review Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: Tiansu Yu <tiansu.yu@icloud> Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
sungwy
added a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* fix (issue-1079): allow update_column to set doc as '' * fix (issue-1079): add test for required and fix version * Apply suggestions from code review Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: Tiansu Yu <tiansu.yu@icloud> Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue#1079
update_columnshould be able to update / removedoc; andrequiredif field is not an identifier field.