Update create table doc to clarify ID re-assignment #1072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying over a similar sentence from the Java docs: https://iceberg.apache.org/docs/1.5.1/java-api-quickstart/#create-a-schema. Based on my reading of the catalog code, this is true as all the `create_table` implementations end up calling `assign_fresh_schema_ids`, `assign_fresh_partition_spec_ids`, and `assign_fresh_sort_order_ids`. This is useful to understand so newcomers don't have to worry about ID management in any new schemas they are sending into `create_table`.
Fokko
approved these changes
Aug 19, 2024
Contributor
Fokko
left a comment
There was a problem hiding this comment.
Thanks @paulcichonski for raising this PR and clarifying the behavior, this makes sense to me 👍
sungwy
approved these changes
Aug 19, 2024
Collaborator
sungwy
left a comment
There was a problem hiding this comment.
+1 thank you for adding this documentation!
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
Copying over a similar sentence from the Java docs: https://iceberg.apache.org/docs/1.5.1/java-api-quickstart/#create-a-schema. Based on my reading of the catalog code, this is true as all the `create_table` implementations end up calling `assign_fresh_schema_ids`, `assign_fresh_partition_spec_ids`, and `assign_fresh_sort_order_ids`. This is useful to understand so newcomers don't have to worry about ID management in any new schemas they are sending into `create_table`.
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
Copying over a similar sentence from the Java docs: https://iceberg.apache.org/docs/1.5.1/java-api-quickstart/#create-a-schema. Based on my reading of the catalog code, this is true as all the `create_table` implementations end up calling `assign_fresh_schema_ids`, `assign_fresh_partition_spec_ids`, and `assign_fresh_sort_order_ids`. This is useful to understand so newcomers don't have to worry about ID management in any new schemas they are sending into `create_table`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying over a similar sentence from the Java docs: https://iceberg.apache.org/docs/1.5.1/java-api-quickstart/#create-a-schema. Based on my reading of the catalog code, this is true as all the
create_tableimplementations end up callingassign_fresh_schema_ids,assign_fresh_partition_spec_ids, andassign_fresh_sort_order_ids.This is useful to understand so newcomers don't have to worry about ID management in any new schemas they are sending into
create_table.