Coverage Run unit tests first before docker containers are set up #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f86746 to
349c9b6
Compare
sungwy
reviewed
Aug 13, 2024
349c9b6 to
244f635
Compare
sungwy
approved these changes
Aug 13, 2024
Collaborator
sungwy
left a comment
There was a problem hiding this comment.
Thank you @Minfante377 for this PR, and @youssef-itanii as well!
kevinjqliu
reviewed
Aug 14, 2024
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Added a comment about testing this method and some nits
Makefile
Outdated
| docker compose -f dev/docker-compose-integration.yml cp ./dev/provision.py spark-iceberg:/opt/spark/provision.py | ||
| docker compose -f dev/docker-compose-integration.yml exec -T spark-iceberg ipython ./provision.py | ||
| poetry run coverage run --source=pyiceberg/ -m pytest tests/ ${PYTEST_ARGS} | ||
| poetry run coverage run --data-file=.coverage.integration --source=pyiceberg/ -m pytest tests/ -m integration ${PYTEST_ARGS} |
Contributor
There was a problem hiding this comment.
nit: to match the other command, also added -v to match test-integration
Suggested change
| poetry run coverage run --data-file=.coverage.integration --source=pyiceberg/ -m pytest tests/ -m integration ${PYTEST_ARGS} | |
| poetry run coverage run --source=pyiceberg/ --data-file=.coverage.integration -m pytest tests/ -v -m integration ${PYTEST_ARGS} |
| assert len(batches) == entries | ||
|
|
||
|
|
||
| @pytest.mark.integration |
Contributor
There was a problem hiding this comment.
Does CI fail if we don't add this line? It's what we're testing for in #1051
Contributor
Author
There was a problem hiding this comment.
It fails indeed. If I don't add that marker the test-coverage-unit command will try to run that test without initializing any docker container
244f635 to
09b0298
Compare
kevinjqliu
approved these changes
Aug 14, 2024
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
Verified that unit test fails
#1060
https://github.com/apache/iceberg-python/actions/runs/10380009878/job/28739139875?pr=1060
=========================== short test summary info ============================
FAILED tests/integration/test_reads.py::test_table_scan_default_to_large_types[session_catalog_hive] - thrift.transport.TTransport.TTransportException: Could not connect to any of [('::1', 9083, 0, 0), ('127.0.0.1', 9083)]
ERROR tests/integration/test_reads.py::test_table_scan_default_to_large_types[session_catalog] - requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=8181): Max retries exceeded with url: /v1/config (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f2b1351e0d0>: Failed to establish a new connection: [Errno 111] Connection refused'))
=== 1 failed, 2781 passed, 834 deselected, 1113 warnings, 1 error in 54.83s ====
This was referenced Aug 14, 2024
Closed
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements:
Should close #1051