Support Array type in log table (Arrow row format)#1987
Merged
wuchong merged 2 commits intoapache:mainapache/fluss:mainfrom Nov 24, 2025
XuQianJin-Stars:feature/issue-1972-array-in-log-tableXuQianJin-Stars/fluss:feature/issue-1972-array-in-log-tableCopy head branch name to clipboard
Merged
Support Array type in log table (Arrow row format)#1987wuchong merged 2 commits intoapache:mainapache/fluss:mainfrom XuQianJin-Stars:feature/issue-1972-array-in-log-tableXuQianJin-Stars/fluss:feature/issue-1972-array-in-log-tableCopy head branch name to clipboard
wuchong merged 2 commits intoapache:mainapache/fluss:mainfrom
XuQianJin-Stars:feature/issue-1972-array-in-log-tableXuQianJin-Stars/fluss:feature/issue-1972-array-in-log-tableCopy head branch name to clipboard
Conversation
1cb52e9 to
d02b31f
Compare
2 tasks
30029fa to
e588330
Compare
29d60c8 to
3620267
Compare
Member
|
@XuQianJin-Stars @platinumhamburg I have reviewed and polished the pull request. Please take a look. It mainly reverts some changes that not necessary and improved the implementation. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1972 #1975
This PR removes the
getMap()andgetRow()methods fromDataGettersinterface and all implementing classes, as these methods are not yet fully supported and will be added later in Issue #1973 (Map support) and Issue #1974 (Row support). Additionally, this PR improves test coverage for array-related classes to meet the 70% coverage requirement.Brief change log
API Changes:
getMap(int pos)method fromDataGettersinterface and all implementations (9 classes: BinaryArray, GenericArray, GenericRow, IndexedRow, AlignedRow, ProjectedRow, ColumnarRow, ColumnarArray, CompactedRow)getRow(int pos, int numFields)method fromDataGettersinterface and all implementationsInternalArray.createElementGetter()to throwIllegalArgumentExceptionfor MAP and ROW typesInternalRow.createFieldGetter()to throwIllegalArgumentExceptionfor MAP and ROW typesgetMap()andgetRow()helper methods fromVectorizedColumnBatchTest Improvements:
getMap()andgetRow()methods:InternalArrayTest.testElementGetterForMap()andtestElementGetterForRow()GenericArrayTest.testNestedRow()InternalArrayAssertto handle MAP type as unsupportedCode Cleanup:
InternalMap,InternalRow,DataTypeRoot,DataField,DataTypeChecksgetDataTypes()from IndexedRowTests
Unit Tests:
InternalArraySerializerTest:testToBinaryArrayFromGenericArrayWithBytes,testEqualsWithNull,testCopyGenericArrayAllNullsBinaryArrayTest:testGetSizeInBytes,testCopyWithMultipleTypes,testHashCodeConsistencyBinarySegmentUtilsTest:testSetBoolean/Byte/Short/Int/Float/Double,testBitSetAndUnSet,testReadBinary,testCopyToBytesmvn clean verify -pl fluss-test-coveragepasses with all classes meeting 70% coverage requirementAPI and Format
API Changes (Breaking):
getMap()andgetRow()fromDataGettersinterfaceNo format changes.
Documentation