Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[opt](storage vault) Check s3.root.path cannot be empty #47078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2025
Merged

[opt](storage vault) Check s3.root.path cannot be empty #47078

merged 1 commit into from
Jan 18, 2025

Conversation

SWJTU-ZhangLei
Copy link
Contributor

@SWJTU-ZhangLei SWJTU-ZhangLei commented Jan 16, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@SWJTU-ZhangLei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32327 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 318071b7ef8fe22516e8d7cf454ae9e1f6229745, data reload: false

------ Round 1 ----------------------------------
q1	17578	5523	5475	5475
q2	2052	296	165	165
q3	10437	1241	749	749
q4	10205	973	546	546
q5	7527	2397	2174	2174
q6	193	169	138	138
q7	918	769	600	600
q8	9259	1375	1230	1230
q9	5109	4831	4838	4831
q10	6798	2346	1870	1870
q11	455	278	258	258
q12	353	355	223	223
q13	17770	3735	3060	3060
q14	222	230	216	216
q15	539	485	469	469
q16	620	606	583	583
q17	573	883	337	337
q18	7041	6457	6294	6294
q19	2255	956	551	551
q20	308	318	190	190
q21	2849	2220	2052	2052
q22	367	343	316	316
Total cold run time: 103428 ms
Total hot run time: 32327 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5596	5556	5586	5556
q2	244	342	231	231
q3	2292	2660	2309	2309
q4	1483	1784	1372	1372
q5	4336	4757	4663	4663
q6	172	162	128	128
q7	2113	1998	1854	1854
q8	2622	2819	2747	2747
q9	7259	7181	7279	7181
q10	3058	3285	2819	2819
q11	576	511	487	487
q12	646	727	593	593
q13	3507	3889	3282	3282
q14	290	310	279	279
q15	525	464	473	464
q16	637	689	662	662
q17	1236	1769	1266	1266
q18	7755	7537	7229	7229
q19	864	1177	1116	1116
q20	1996	2058	1900	1900
q21	5830	5297	5006	5006
q22	629	640	587	587
Total cold run time: 53666 ms
Total hot run time: 51731 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194413 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 318071b7ef8fe22516e8d7cf454ae9e1f6229745, data reload: false

query1	1310	970	915	915
query2	6234	2092	1992	1992
query3	10936	4491	4540	4491
query4	61281	28674	23433	23433
query5	5387	639	469	469
query6	439	197	196	196
query7	5547	531	313	313
query8	341	247	238	238
query9	8164	2675	2668	2668
query10	448	316	263	263
query11	17759	15165	15826	15165
query12	161	119	108	108
query13	1420	561	434	434
query14	10773	7231	6702	6702
query15	210	215	185	185
query16	6740	661	480	480
query17	1150	730	557	557
query18	1811	395	316	316
query19	211	192	195	192
query20	115	112	112	112
query21	208	123	103	103
query22	4491	4684	4622	4622
query23	33772	33425	33018	33018
query24	5542	2340	2416	2340
query25	539	475	402	402
query26	748	287	155	155
query27	2064	486	327	327
query28	3837	2501	2446	2446
query29	572	576	426	426
query30	217	195	153	153
query31	955	891	784	784
query32	74	56	65	56
query33	454	361	302	302
query34	765	924	529	529
query35	803	856	811	811
query36	1005	1033	951	951
query37	125	95	78	78
query38	4411	4441	4327	4327
query39	1490	1466	1439	1439
query40	209	116	103	103
query41	53	52	49	49
query42	122	105	102	102
query43	514	544	492	492
query44	1407	842	826	826
query45	187	172	174	172
query46	954	1099	661	661
query47	1922	1896	1830	1830
query48	397	419	325	325
query49	715	511	401	401
query50	701	719	429	429
query51	7067	7173	6994	6994
query52	105	103	93	93
query53	236	265	190	190
query54	493	487	425	425
query55	86	78	81	78
query56	264	270	265	265
query57	1227	1234	1094	1094
query58	229	252	232	232
query59	2835	3106	2789	2789
query60	280	264	255	255
query61	119	116	117	116
query62	755	704	650	650
query63	224	188	191	188
query64	1944	1024	665	665
query65	3311	3177	3195	3177
query66	771	387	302	302
query67	15871	15589	15591	15589
query68	5022	846	530	530
query69	484	353	253	253
query70	1190	1159	1139	1139
query71	425	285	246	246
query72	5245	3998	3916	3916
query73	807	791	367	367
query74	10150	9167	8911	8911
query75	3256	3175	2690	2690
query76	3694	1218	776	776
query77	494	483	288	288
query78	9980	10169	9304	9304
query79	1585	861	599	599
query80	1416	556	456	456
query81	538	284	238	238
query82	348	148	124	124
query83	260	175	154	154
query84	276	99	73	73
query85	836	367	303	303
query86	365	304	307	304
query87	4422	4550	4341	4341
query88	3216	2213	2141	2141
query89	394	336	291	291
query90	1540	188	191	188
query91	135	141	108	108
query92	61	61	54	54
query93	1599	892	524	524
query94	691	406	306	306
query95	332	270	255	255
query96	498	641	278	278
query97	2803	2869	2750	2750
query98	222	202	198	198
query99	1284	1375	1318	1318
Total cold run time: 309075 ms
Total hot run time: 194413 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.24 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 318071b7ef8fe22516e8d7cf454ae9e1f6229745, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.61	0.11	0.11
query5	0.42	0.41	0.41
query6	1.15	0.66	0.64
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.59	0.50	0.49
query10	0.56	0.56	0.55
query11	0.16	0.11	0.10
query12	0.14	0.10	0.11
query13	0.61	0.60	0.60
query14	2.70	2.75	2.83
query15	0.91	0.83	0.83
query16	0.37	0.38	0.39
query17	1.04	1.04	1.04
query18	0.21	0.21	0.21
query19	1.98	1.82	1.96
query20	0.02	0.01	0.01
query21	15.37	0.99	0.61
query22	0.75	0.83	0.79
query23	15.13	1.47	0.57
query24	2.91	0.37	0.75
query25	0.24	0.10	0.13
query26	0.40	0.15	0.13
query27	0.06	0.06	0.06
query28	13.16	1.12	0.44
query29	12.56	3.94	3.31
query30	0.25	0.09	0.06
query31	2.83	0.61	0.38
query32	3.23	0.56	0.46
query33	2.93	3.02	3.03
query34	16.63	5.16	4.48
query35	4.58	4.48	4.52
query36	0.73	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.03
query40	0.16	0.12	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.11 s
Total hot run time: 30.24 s

dataroaring
dataroaring approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou merged commit bb81eda into apache:master Jan 18, 2025
30 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 18, 2025
@SWJTU-ZhangLei
[opt](storage vault) Check s3.root.path cannot be empty (#47078)
34d06d7
@github-actions github-actions bot mentioned this pull request Jan 18, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jan 19, 2025
@github-actions @SWJTU-ZhangLei
branch-3.0: [opt](storage vault) Check s3.root.path cannot be empty #…
089ef91 
…47078 (#47196)

Cherry-picked from #47078

Co-authored-by: Lei Zhang <zhanglei@selectdb.com>
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Open
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@SWJTU-ZhangLei @lzyy2024
[opt](storage vault) Check s3.root.path cannot be empty (apache#47078)
fe00516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SWJTU-ZhangLei @Thearas @doris-robot @gavinchou @dataroaring
Morty Proxy This is a proxified and sanitized view of the page, visit original site.