branch-3.0: [Fix](merge-on-write) Should update pending delete bitmap KVs in MS when no need to calc delete bitmaps in publish phase #46039 #46139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
…hen no need to calc delete bitmaps in publish phase (apache#46039) consider the following situation: 1. Txn A acquires the lock, obtains version X to publish, calculates the delete bitmap, writes the pending delete bitmap KVs to the MS, but fails for some reason before committing the transaction in the MS. 2. Txn B acquires the lock, obtains version X to publish, **cleans up the pending delete bitmap KV written by Txn A**, calculates the delete bitmap, **writes its pending delete bitmap KV to the MS**, but also fails for some reason before committing the transaction in the MS. 3. Txn A then reacquires the lock, obtains version X to publish, and notices that neither the version nor the compaction counts have changed. It will skip the process of calculating the delete bitmap and writing the pending delete bitmap KV to the MS apache#39018 and eventually succeeds in committing the transaction in the MS. In this case, Txn A will save the wrong delete bitmaps(generated by Txn B) in MS and causing correctness problem. To solve the problem, we should still update delete bitmap KVs in MS when we skip the calculation of delete bitmap on BE in publish phase. Also add a defensive check: record `lock_id` when writing pending delete bitmap keys and check if the `lock_id` is correct when commit txn in MS.
84b94a5 to
c85695e
Compare
|
run buildall |
TPC-H: Total hot run time: 40894 ms |
TPC-DS: Total hot run time: 197133 ms |
|
run performance |
TPC-H: Total hot run time: 40755 ms |
TPC-DS: Total hot run time: 198108 ms |
ClickBench: Total hot run time: 33.64 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick #46039