Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[opt](bloomfilter index) optimize memory usage for bloom filter index writer #45833 #46047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

airborne12
Copy link
Member

cherry pick from #45833

… writer (apache#45833)

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Optimize memory usage when adding string values for bloom filter index.
Using uint64 hash value instead of string values itself, it is expected
to save a lot of memory for especially long text
@airborne12
Copy link
Member Author

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@airborne12
Copy link
Member Author

run buildall

@airborne12
Copy link
Member Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.38% (9539/26218)
Line Coverage: 27.90% (78592/281717)
Region Coverage: 26.57% (40343/151819)
Branch Coverage: 23.33% (20430/87578)
Coverage Report: http://coverage.selectdb-in.cc/coverage/00028a7b79338710067dfeba52137a67c34d9cda_00028a7b79338710067dfeba52137a67c34d9cda/report/index.html

@airborne12 airborne12 merged commit d2c1087 into apache:branch-2.1 Dec 27, 2024
17 of 19 checks passed
@airborne12 airborne12 deleted the pick_45833_to_origin_branch-2.1 branch December 27, 2024 04:10
deardeng pushed a commit to deardeng/incubator-doris that referenced this pull request Jan 6, 2025
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.