Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[chore](bash) optimize output information when doris_cloud startup #45883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 23, 2025
Merged

[chore](bash) optimize output information when doris_cloud startup #45883

merged 12 commits into from
Jan 23, 2025

Conversation

yagagagaga
Copy link
Contributor

@yagagagaga yagagagaga commented Dec 24, 2024 •
edited
Loading

What problem does this PR solve?

before:

bash bin/start.sh --daemon --meta-service

LIBHDFS3_CONF=
starts doris_cloud with args: --meta-service
wait and check doris_cloud start successfully
successfully started brpc listening on port=5000 time_elapsed_ms=11
doris_cloud start successfully

after:

bash bin/start.sh --daemon --meta-service

2024-12-26 15:31:53 start with args: --meta-service
wait and check MetaService and Recycler start successfully
process working directory: "/mnt/disk1/zhangminke/ms"
pid=1666015 written to file=./bin/doris_cloud.pid
version:{doris-0.0.0-release} code_version:{commit=fd44740fadabebfedb5da201d7ce427a5dd47c44 time=2025-01-16 18:53:00 +0800} build_info:{initiator=zhangminke@VM-10-6-centos build_at=2025-01-16 18:53:00 +0800 build_on=NAME="TencentOS Server" VERSION="3.1 (Final)" }

use volatile mem kv, please make sure it is not a production environment
MetaService has been started successfully
successfully started service listening on port=23415 time_elapsed_ms=19

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

gavinchou
gavinchou reviewed Dec 25, 2024
View reviewed changes
cloud/script/start.sh Outdated
@@ -141,7 +141,7 @@ if [[ "${RUN_DAEMON}" -eq 1 ]]; then
echo "${process} may not start successfully please check process log for more details"
exit 1
fi
echo "${process} start successfully"
tail -n10 "${out_file}" | grep -E '(recycler|meta-service) started'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also grep version

@yagagagaga
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

TangSiyang2001
TangSiyang2001 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@TangSiyang2001 TangSiyang2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou merged commit 40d2aad into apache:master Jan 23, 2025
29 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
@yagagagaga
[chore](bash) optimize output information when doris_cloud startup (#…
58529b4 
…45883)

before:
```
bash bin/start.sh --daemon --meta-service

LIBHDFS3_CONF=
starts doris_cloud with args: --meta-service
wait and check doris_cloud start successfully
successfully started brpc listening on port=5000 time_elapsed_ms=11
doris_cloud start successfully

```

after:
```
bash bin/start.sh --daemon --meta-service

2024-12-26 15:31:53 start with args: --meta-service
wait and check MetaService and Recycler start successfully
process working directory: "/mnt/disk1/zhangminke/ms"
pid=1666015 written to file=./bin/doris_cloud.pid
version:{doris-0.0.0-release} code_version:{commit=fd44740fadabebfedb5da201d7ce427a5dd47c44 time=2025-01-16 18:53:00 +0800} build_info:{initiator=zhangminke@VM-10-6-centos build_at=2025-01-16 18:53:00 +0800 build_on=NAME="TencentOS Server" VERSION="3.1 (Final)" }

use volatile mem kv, please make sure it is not a production environment
MetaService has been started successfully
successfully started service listening on port=23415 time_elapsed_ms=19
```
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Merged
dataroaring pushed a commit that referenced this pull request Feb 12, 2025
@github-actions @yagagagaga
branch-3.0: [chore](bash) optimize output information when doris_clou…
8986571 
…d startup #45883 (#47345)

Cherry-picked from #45883

Co-authored-by: yagagagaga <zhangminke@selectdb.com>
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Open
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@yagagagaga @lzyy2024
[chore](bash) optimize output information when doris_cloud startup (a…
c383bfe 
…pache#45883)

before:
```
bash bin/start.sh --daemon --meta-service

LIBHDFS3_CONF=
starts doris_cloud with args: --meta-service
wait and check doris_cloud start successfully
successfully started brpc listening on port=5000 time_elapsed_ms=11
doris_cloud start successfully

```

after:
```
bash bin/start.sh --daemon --meta-service

2024-12-26 15:31:53 start with args: --meta-service
wait and check MetaService and Recycler start successfully
process working directory: "/mnt/disk1/zhangminke/ms"
pid=1666015 written to file=./bin/doris_cloud.pid
version:{doris-0.0.0-release} code_version:{commit=fd44740fadabebfedb5da201d7ce427a5dd47c44 time=2025-01-16 18:53:00 +0800} build_info:{initiator=zhangminke@VM-10-6-centos build_at=2025-01-16 18:53:00 +0800 build_on=NAME="TencentOS Server" VERSION="3.1 (Final)" }

use volatile mem kv, please make sure it is not a production environment
MetaService has been started successfully
successfully started service listening on port=23415 time_elapsed_ms=19
```
@yagagagaga yagagagaga deleted the optimize_output branch February 25, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinchou gavinchou gavinchou approved these changes

@TangSiyang2001 TangSiyang2001 TangSiyang2001 approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yagagagaga @hello-stephen @gavinchou @TangSiyang2001 @dataroaring
Morty Proxy This is a proxified and sanitized view of the page, visit original site.