Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[improvement](information_schema)Support show default value in information_schema. #44849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Dec 2, 2024

What problem does this PR solve?

The COLUMN_DEFAULT column in INFORMATION_SCHEMA.COLUMNS table is always NULL, this PR set the correct default value for COLUMN_DEFAULT.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review December 2, 2024 06:46
@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40242 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a9ee878da9aaaf998d17c149266a73a587a3d6a5, data reload: false

------ Round 1 ----------------------------------
q1	17624	7477	7286	7286
q2	2071	183	174	174
q3	10673	1105	1232	1105
q4	10310	707	768	707
q5	7609	2753	2668	2668
q6	246	154	151	151
q7	1097	627	601	601
q8	9248	1840	1928	1840
q9	6648	6610	6574	6574
q10	7061	2337	2313	2313
q11	468	265	256	256
q12	426	215	229	215
q13	17799	2981	3052	2981
q14	243	211	210	210
q15	569	526	526	526
q16	658	594	590	590
q17	979	625	610	610
q18	7293	6832	6761	6761
q19	1343	1018	950	950
q20	470	182	181	181
q21	4117	3271	3232	3232
q22	377	312	311	311
Total cold run time: 107329 ms
Total hot run time: 40242 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7278	7246	7203	7203
q2	321	231	234	231
q3	2920	2876	2972	2876
q4	2112	1788	1859	1788
q5	5631	5671	5670	5670
q6	219	141	135	135
q7	2256	1773	1832	1773
q8	3346	3543	3523	3523
q9	8885	9062	8962	8962
q10	3609	3547	3577	3547
q11	595	504	486	486
q12	777	583	594	583
q13	11786	3261	3189	3189
q14	300	268	271	268
q15	569	533	551	533
q16	702	635	635	635
q17	1862	1613	1604	1604
q18	8257	7694	7476	7476
q19	1697	1578	1568	1568
q20	2117	1880	1835	1835
q21	5598	5558	5357	5357
q22	682	609	595	595
Total cold run time: 71519 ms
Total hot run time: 59837 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196782 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a9ee878da9aaaf998d17c149266a73a587a3d6a5, data reload: false

query1	1271	958	916	916
query2	6268	2056	2057	2056
query3	11099	4625	4449	4449
query4	66653	29035	23715	23715
query5	4915	468	443	443
query6	416	183	191	183
query7	5617	310	312	310
query8	337	241	234	234
query9	9080	2693	2705	2693
query10	457	244	247	244
query11	17562	15333	15770	15333
query12	153	108	105	105
query13	1575	457	427	427
query14	10496	7004	7208	7004
query15	223	191	195	191
query16	7238	496	494	494
query17	1233	603	549	549
query18	1869	304	318	304
query19	200	158	148	148
query20	114	112	146	112
query21	212	104	102	102
query22	4731	4529	4400	4400
query23	35114	34350	34548	34350
query24	5497	2490	2427	2427
query25	502	376	389	376
query26	641	150	150	150
query27	1859	289	282	282
query28	4510	2489	2498	2489
query29	673	425	422	422
query30	210	147	148	147
query31	994	853	854	853
query32	63	56	54	54
query33	402	280	289	280
query34	913	536	519	519
query35	885	773	743	743
query36	1081	927	967	927
query37	123	73	69	69
query38	4473	4363	4489	4363
query39	1506	1471	1450	1450
query40	194	100	101	100
query41	47	43	44	43
query42	105	99	95	95
query43	530	500	489	489
query44	1178	835	821	821
query45	185	174	171	171
query46	1169	709	702	702
query47	2060	1973	1928	1928
query48	409	325	311	311
query49	731	397	402	397
query50	842	395	390	390
query51	7396	7273	7054	7054
query52	103	84	85	84
query53	263	172	173	172
query54	503	389	387	387
query55	75	72	75	72
query56	253	224	257	224
query57	1304	1151	1100	1100
query58	212	203	202	202
query59	3268	3234	2918	2918
query60	261	245	234	234
query61	109	107	109	107
query62	787	655	692	655
query63	205	192	194	192
query64	1389	701	638	638
query65	3248	3183	3251	3183
query66	674	296	293	293
query67	15904	15636	15551	15551
query68	4207	557	541	541
query69	420	252	237	237
query70	1131	1060	1064	1060
query71	346	243	244	243
query72	6387	4141	4082	4082
query73	766	363	363	363
query74	10180	9044	8967	8967
query75	3391	2652	2646	2646
query76	1945	1086	1064	1064
query77	471	260	268	260
query78	10474	9604	9510	9510
query79	1187	603	594	594
query80	854	424	428	424
query81	480	227	223	223
query82	1311	122	117	117
query83	248	140	143	140
query84	285	69	76	69
query85	878	320	303	303
query86	334	302	300	300
query87	4664	4507	4591	4507
query88	3484	2212	2174	2174
query89	409	295	297	295
query90	1945	182	187	182
query91	132	108	98	98
query92	65	54	48	48
query93	1291	550	538	538
query94	774	298	254	254
query95	344	244	243	243
query96	617	272	267	267
query97	2889	2707	2716	2707
query98	219	205	190	190
query99	1576	1310	1329	1310
Total cold run time: 318273 ms
Total hot run time: 196782 ms

@Jibing-Li
Copy link
Contributor Author

run performance

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.39% (9977/25989)
Line Coverage: 29.45% (83659/284066)
Region Coverage: 28.59% (43057/150618)
Branch Coverage: 25.21% (21890/86836)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a9ee878da9aaaf998d17c149266a73a587a3d6a5_a9ee878da9aaaf998d17c149266a73a587a3d6a5/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 39863 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a9ee878da9aaaf998d17c149266a73a587a3d6a5, data reload: false

------ Round 1 ----------------------------------
q1	18011	8618	7298	7298
q2	2042	181	167	167
q3	10734	1108	1185	1108
q4	10541	734	748	734
q5	7616	2702	2655	2655
q6	240	147	145	145
q7	993	625	614	614
q8	9246	1855	1918	1855
q9	6647	6495	6536	6495
q10	6987	2255	2350	2255
q11	479	261	247	247
q12	433	220	228	220
q13	17775	3010	3017	3010
q14	237	211	222	211
q15	589	541	527	527
q16	635	596	605	596
q17	963	599	480	480
q18	7404	6647	6979	6647
q19	1358	1100	906	906
q20	468	181	177	177
q21	3954	3199	3209	3199
q22	385	320	317	317
Total cold run time: 107737 ms
Total hot run time: 39863 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7281	7292	7280	7280
q2	331	241	231	231
q3	2904	2939	3117	2939
q4	2064	1846	1888	1846
q5	5591	5665	5668	5665
q6	233	144	142	142
q7	2231	1839	1817	1817
q8	3356	3553	3534	3534
q9	8806	9045	9061	9045
q10	3621	3547	3577	3547
q11	598	519	497	497
q12	798	596	627	596
q13	12163	3316	3259	3259
q14	317	269	277	269
q15	571	519	531	519
q16	700	660	650	650
q17	1854	1629	1642	1629
q18	8255	7850	7546	7546
q19	1669	1625	1593	1593
q20	2121	1863	1873	1863
q21	5636	5451	5394	5394
q22	659	592	567	567
Total cold run time: 71759 ms
Total hot run time: 60428 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197226 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a9ee878da9aaaf998d17c149266a73a587a3d6a5, data reload: false

query1	1279	961	938	938
query2	6259	2084	2069	2069
query3	10940	4548	4360	4360
query4	67091	28749	23703	23703
query5	4960	462	462	462
query6	408	178	183	178
query7	5464	302	297	297
query8	333	231	235	231
query9	8591	2688	2724	2688
query10	443	246	257	246
query11	17172	15404	16022	15404
query12	162	101	99	99
query13	1397	414	423	414
query14	10175	7146	6655	6655
query15	216	198	206	198
query16	7138	440	460	440
query17	1188	582	597	582
query18	1860	337	302	302
query19	199	163	155	155
query20	136	115	115	115
query21	214	114	105	105
query22	4772	4634	4356	4356
query23	34792	34721	34646	34646
query24	5381	2527	2511	2511
query25	508	390	388	388
query26	634	155	156	155
query27	1786	283	312	283
query28	4213	2498	2498	2498
query29	674	415	409	409
query30	210	147	148	147
query31	992	875	856	856
query32	62	53	52	52
query33	455	288	291	288
query34	958	524	535	524
query35	911	802	754	754
query36	1108	947	950	947
query37	122	72	91	72
query38	4523	4552	4498	4498
query39	1513	1502	1471	1471
query40	209	99	99	99
query41	45	42	41	41
query42	107	98	99	98
query43	543	508	518	508
query44	1205	840	812	812
query45	194	171	177	171
query46	1202	711	718	711
query47	2049	1977	1957	1957
query48	420	304	317	304
query49	724	418	427	418
query50	862	393	408	393
query51	7439	7240	7041	7041
query52	100	90	88	88
query53	254	185	177	177
query54	514	405	390	390
query55	77	75	77	75
query56	257	269	232	232
query57	1275	1171	1118	1118
query58	214	211	213	211
query59	3372	3016	2990	2990
query60	262	234	230	230
query61	104	103	99	99
query62	798	674	665	665
query63	213	190	196	190
query64	1372	651	615	615
query65	3250	3197	3234	3197
query66	704	299	301	299
query67	16075	15555	15681	15555
query68	3689	579	568	568
query69	426	267	256	256
query70	1170	1094	1106	1094
query71	354	247	257	247
query72	6408	4158	4043	4043
query73	780	356	373	356
query74	10189	9033	9016	9016
query75	3377	2666	2654	2654
query76	1893	1045	1118	1045
query77	468	276	272	272
query78	10490	9484	9493	9484
query79	1551	623	590	590
query80	873	520	428	428
query81	498	228	237	228
query82	1302	125	118	118
query83	252	149	143	143
query84	290	73	69	69
query85	895	296	309	296
query86	341	307	308	307
query87	4797	4479	4623	4479
query88	3625	2193	2179	2179
query89	425	352	288	288
query90	1989	191	190	190
query91	147	102	105	102
query92	67	54	52	52
query93	1850	535	544	535
query94	776	293	298	293
query95	344	251	246	246
query96	603	277	280	277
query97	2885	2683	2679	2679
query98	221	191	189	189
query99	1592	1335	1323	1323
Total cold run time: 317646 ms
Total hot run time: 197226 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.7 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a9ee878da9aaaf998d17c149266a73a587a3d6a5, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.04	0.05
query3	0.23	0.06	0.05
query4	1.66	0.09	0.11
query5	0.43	0.40	0.41
query6	1.17	0.66	0.67
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.56	0.51	0.49
query10	0.56	0.55	0.54
query11	0.17	0.12	0.12
query12	0.16	0.14	0.14
query13	0.62	0.61	0.60
query14	2.72	2.72	2.72
query15	0.93	0.85	0.84
query16	0.38	0.38	0.39
query17	1.04	1.07	1.05
query18	0.19	0.19	0.19
query19	1.83	1.89	2.05
query20	0.01	0.01	0.02
query21	15.37	0.68	0.67
query22	4.27	6.40	2.30
query23	18.24	1.29	1.29
query24	2.10	0.23	0.23
query25	0.14	0.09	0.09
query26	0.28	0.19	0.18
query27	0.08	0.08	0.08
query28	13.18	1.17	1.15
query29	12.67	3.40	3.36
query30	0.24	0.06	0.05
query31	2.88	0.40	0.40
query32	3.23	0.49	0.50
query33	3.03	3.01	3.07
query34	17.01	4.48	4.58
query35	4.51	4.60	4.53
query36	0.67	0.49	0.48
query37	0.19	0.16	0.16
query38	0.15	0.16	0.15
query39	0.06	0.05	0.04
query40	0.16	0.13	0.13
query41	0.10	0.05	0.05
query42	0.07	0.06	0.05
query43	0.05	0.05	0.04
Total cold run time: 111.52 s
Total hot run time: 33.7 s

Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by anyone and no changes requested.

@Jibing-Li Jibing-Li merged commit 5ff94a1 into apache:master Dec 6, 2024
29 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 6, 2024
…ation_schema. (#44849)

### What problem does this PR solve?

The COLUMN_DEFAULT column in INFORMATION_SCHEMA.COLUMNS table is always
NULL, this PR set the correct default value for COLUMN_DEFAULT.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None
github-actions bot pushed a commit that referenced this pull request Dec 6, 2024
…ation_schema. (#44849)

### What problem does this PR solve?

The COLUMN_DEFAULT column in INFORMATION_SCHEMA.COLUMNS table is always
NULL, this PR set the correct default value for COLUMN_DEFAULT.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None
@Jibing-Li Jibing-Li deleted the defaultvalue branch December 6, 2024 02:50
Jibing-Li added a commit that referenced this pull request Dec 6, 2024
…ue in information_schema. #44849 (#45080)

Cherry-picked from #44849

Co-authored-by: James <lijibing@selectdb.com>
Jibing-Li added a commit that referenced this pull request Dec 6, 2024
…ue in information_schema. #44849 (#45079)

Cherry-picked from #44849

Co-authored-by: James <lijibing@selectdb.com>
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
@wm1581066 wm1581066 added the usercase Important user case type label label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.