Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Spark load][Be 1/1] Be handle push task #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 22, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change functionName finalize to close
  • Loading branch information
xy720 committed Jun 4, 2020
commit 32770821db2c5912dfcefab5e2c7707a495c3dc2
2 changes: 1 addition & 1 deletion 2 be/src/olap/push_handler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ OLAPStatus PushHandler::_convert(TabletSharedPtr cur_tablet,
}
}

reader->finalize();
reader->close();
xy720 marked this conversation as resolved.
Show resolved Hide resolved

if (!reader->validate_checksum()) {
LOG(WARNING) << "pushed delta file has wrong checksum.";
Expand Down
2 changes: 1 addition & 1 deletion 2 be/src/olap/push_handler.h
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ class PushBrokerReader {
OLAPStatus next(ContiguousRow* row);
void print_profile();

OLAPStatus finalize() {
OLAPStatus close() {
_ready = false;
return OLAP_SUCCESS;
}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.