Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@zhan7236
Copy link
Contributor

@zhan7236 zhan7236 commented Nov 26, 2025

What is the purpose of the pull request

This PR performs a comprehensive update of the DolphinScheduler Helm charts to ensure compatibility with the new versions of Bitnami charts, as outlined in issue #17560.

The main changes include:

  1. Migrating from bitnamilegacy/* images to official bitnami/* images
  2. Updating Helm chart dependency versions
  3. Adapting configuration formats to match new Bitnami chart requirements

Brief change log

Chart Version Updates:

  • Update PostgreSQL chart from 10.3.18 to 12.1.5
  • Update Zookeeper chart from 11.4.11 to 13.8.7
  • Update MySQL chart from 9.4.1 to 9.23.0
  • Update MinIO chart from 11.10.13 to 12.13.2

Image Updates (migrating from bitnamilegacy to bitnami):

  • PostgreSQL: bitnamilegacy/postgresql:11.11.0bitnami/postgresql:15.1.0-debian-11-r12
  • Zookeeper: bitnamilegacy/zookeeper:3.8.4bitnami/zookeeper:3.9.3-debian-12-r21
  • MySQL: bitnamilegacy/mysql:8.0.31bitnami/mysql:8.0.36-debian-12-r8
  • MinIO: bitnamilegacy/minio:2022.10.29bitnami/minio:2023.12.23-debian-11-r3

Configuration Format Updates:

  • PostgreSQL: Migrate from postgresqlUsername/Password/Database to auth.username/password/database
  • PostgreSQL: Migrate persistence.* to primary.persistence.*
  • Update _helpers.tpl to use new PostgreSQL auth config structure
  • Update keda-autoscaler-worker.yaml to use new PostgreSQL auth config

Repository Migration:

  • Migrate all dependencies from https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami to https://charts.bitnami.com/bitnami
  • Remove outdated comments about Bitnami repository changes

Verify this pull request

This PR has been verified by:

  • helm dependency update - All charts downloaded successfully
  • helm template test . - Template rendering works correctly

Related Issues

Closes #17560
Closes #17561
Closes #17562
Closes #17563
Closes #17564

@zhan7236 zhan7236 requested a review from Gallardot as a code owner November 26, 2025 01:50
@SbloodyS SbloodyS requested a review from Copilot November 26, 2025 01:54
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Nov 26, 2025
@SbloodyS SbloodyS added this to the 3.4.0 milestone Nov 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Bitnami Helm chart versions for three key dependencies (PostgreSQL, MySQL, and Zookeeper) and migrates them from the legacy archive-full-index repository to the current Bitnami chart repository. The updates represent significant version jumps: PostgreSQL from 10.3.18 to 17.0.1, MySQL from 9.4.1 to 14.0.4, and Zookeeper from 11.4.11 to 13.8.8.

However, the PR has critical compatibility issues that will prevent successful deployment:

  • Critical Breaking Changes: The PostgreSQL chart v17.0.1 uses a completely different configuration schema and secret structure than what's currently implemented in values.yaml and the Helm templates, which will cause deployment failures.
  • Configuration Mismatches: Parameter names have changed in the new chart versions (e.g., postgresqlUsernameauth.username), but these updates are not reflected in the values file.
  • Incomplete Migration: The minio dependency still references the old archive repository, creating inconsistency with the stated migration goal.
Comments suppressed due to low confidence (1)

deploy/kubernetes/dolphinscheduler/Chart.yaml:60

  • The minio dependency still uses the legacy archive-full-index repository while PostgreSQL, MySQL, and Zookeeper have been updated to use the current Bitnami repository. For consistency, minio should also be updated to use https://charts.bitnami.com/bitnami if a compatible version is available in the current repository.
- name: minio
  version: 11.10.13
  repository: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami
  condition: minio.enabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

# contains the full 'index.yaml'.
# See detail here: https://github.com/bitnami/charts/issues/10833
repository: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami
version: 17.0.1
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to PostgreSQL chart v17.0.1 introduces breaking changes that require updates to values.yaml and templates/_helpers.tpl:

  1. Configuration parameters: The chart uses a new schema where postgresqlUsername, postgresqlPassword, and postgresqlDatabase should be changed to auth.username, auth.password, and auth.database in values.yaml (lines 60-64).

  2. Secret key names: The password secret key changed from postgresql-password to password. The template reference at templates/_helpers.tpl:173 needs to be updated accordingly.

  3. Service name: The default PostgreSQL service name format may have changed, potentially affecting the connection string at templates/_helpers.tpl:154.

Without these updates, the PostgreSQL deployment will either fail or DolphinScheduler pods will be unable to connect to the database. Consider updating to an intermediate chart version first, or ensure all necessary configuration updates are included in this PR.

Suggested change
version: 17.0.1
version: 12.1.5

Copilot uses AI. Check for mistakes.
version: 11.4.11
# Same as above.
repository: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami
version: 13.8.8
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Zookeeper chart version 13.8.8 may have renamed configuration parameters. Notably, fourlwCommandsWhitelist was changed to fourlwCommandsAllowlist in Bitnami Zookeeper chart v12.x and above to use more inclusive language. The values.yaml file should be checked and updated to use the correct parameter name compatible with chart version 13.8.8 to avoid configuration issues.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests failed. Please check it. @zhan7236

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

@Mrhs121
Copy link
Contributor

Mrhs121 commented Dec 12, 2025

According to Bitnami’s official notice, after 28 Aug 2025:

  • docker.io/bitnami will only contain a hardened, latest-tag-only community subset; no historical versions will be kept there.
  • ZooKeeper, MinIO, MYSQL and any image not in that subset will disappear from the free catalog. Currently, zookeeper, minio and mysql images or tags cannot be retrieved in the bitnamisecure repository and bitnami repository
  • Existing tags (including ZooKeeper/MinIO/Mysql) are moved to docker.io/bitnamilegacy but receive no further updates or security fixes.

@Gallardot I think it's not appropriate to directly replace all of repository:bitnamilegacy with repository:bitnami here

@Gallardot
Copy link
Member

According to Bitnami’s official notice, after 28 Aug 2025:

  • docker.io/bitnami will only contain a hardened, latest-tag-only community subset; no historical versions will be kept there.
  • ZooKeeper, MinIO, MYSQL and any image not in that subset will disappear from the free catalog. Currently, zookeeper, minio and mysql images or tags cannot be retrieved in the bitnamisecure repository and bitnami repository
  • Existing tags (including ZooKeeper/MinIO/Mysql) are moved to docker.io/bitnamilegacy but receive no further updates or security fixes.

@Gallardot I think it's not appropriate to directly replace all of repository:bitnamilegacy with repository:bitnami here

Yes, it's not just about replacing the docker image. Helm charts themselves also have some configurations that need to be adapted.

…Bitnami repository

- Update PostgreSQL chart from 10.3.18 to 12.1.5 (recommended by Copilot AI review)
- Update Zookeeper chart from 11.4.11 to 13.8.7 (latest stable in 13.8.x series)
- Update MySQL chart from 9.4.1 to 9.23.0 (backward compatible)
- Update MinIO chart from 11.10.13 to 12.13.2 (backward compatible)
- Migrate all dependencies from archive-full-index to current Bitnami repository
- Remove outdated comments about Bitnami repository changes

This conservative update approach:
- Uses PostgreSQL 12.1.5 as suggested to avoid breaking configuration schema changes
- Maintains backward compatibility with existing values.yaml and templates
- Migrates from legacy Bitnami registry to current repository
- All dependencies verified to download successfully from new repository

Addresses Copilot AI review feedback about breaking changes in newer chart versions.

Closes apache#17561
Closes apache#17562
Closes apache#17563

Part of apache#17560
…cy images

- Update PostgreSQL chart from 10.3.18 to 12.1.5
  - Migrate config from postgresqlUsername/Password/Database to auth.username/password/database
  - Migrate persistence from root level to primary.persistence
  - Update image from bitnamilegacy/postgresql:11.11.0 to bitnami/postgresql:15.1.0-debian-11-r12

- Update Zookeeper chart from 11.4.11 to 13.8.7
  - Update image from bitnamilegacy/zookeeper:3.8.4 to bitnami/zookeeper:3.9.3-debian-12-r21

- Update MySQL chart from 9.4.1 to 9.23.0
  - Update image from bitnamilegacy/mysql:8.0.31 to bitnami/mysql:8.0.36-debian-12-r8

- Update MinIO chart from 11.10.13 to 12.13.2
  - Update image from bitnamilegacy/minio:2022.10.29 to bitnami/minio:2023.12.23-debian-11-r3

- Update templates to use new PostgreSQL auth.* config structure
  - _helpers.tpl: Update database env vars references
  - keda-autoscaler-worker.yaml: Update PostgreSQL trigger metadata

- Migrate all repositories from archive-full-index to current Bitnami repository
Auto-generated by helm-docs for the updated chart configurations.
The new Bitnami PostgreSQL chart version 12.1.5 uses 'password' as the
secret key instead of 'postgresql-password'. This change aligns the
DolphinScheduler Helm chart with the new Bitnami chart format.

This fix resolves the E2E-K8S test failure caused by the post-install
hook timing out when trying to read the PostgreSQL password from the
wrong secret key.
…icy change

After August 28, 2025, ZooKeeper, MySQL, MinIO and specific version tags of
PostgreSQL will be removed from docker.io/bitnami and moved to bitnamilegacy.

This change:
- Updates postgresql image repository to bitnamilegacy/postgresql
- Updates mysql image repository to bitnamilegacy/mysql
- Updates minio image repository to bitnamilegacy/minio
- Updates zookeeper image repository to bitnamilegacy/zookeeper

The Helm chart versions remain updated to use the new configuration format
(auth.username, auth.password, etc.) which are compatible with bitnamilegacy images.
…images

The new Bitnami Helm charts (postgresql 12.1.5, zookeeper 13.8.7, etc.)
include image signature verification that rejects non-standard images
like bitnamilegacy. This causes Helm install to fail with:

  ERROR: Original containers have been substituted for unrecognized ones.
  Unrecognized images: docker.io/bitnamilegacy/zookeeper:3.9.3-debian-12-r21

Setting global.security.allowInsecureImages: true allows the use of
bitnamilegacy images with the newer chart versions.

Reference: bitnami/charts#30850
@SbloodyS SbloodyS modified the milestones: 3.4.0, 3.4.1 Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

document improvement make more easy to user or prompt friendly kubernetes

Projects

None yet

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.