-
Notifications
You must be signed in to change notification settings - Fork 5k
[Improvement-17560][Helm] Update Bitnami chart versions for PostgreSQL, MySQL and Zookeeper #17730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Bitnami Helm chart versions for three key dependencies (PostgreSQL, MySQL, and Zookeeper) and migrates them from the legacy archive-full-index repository to the current Bitnami chart repository. The updates represent significant version jumps: PostgreSQL from 10.3.18 to 17.0.1, MySQL from 9.4.1 to 14.0.4, and Zookeeper from 11.4.11 to 13.8.8.
However, the PR has critical compatibility issues that will prevent successful deployment:
- Critical Breaking Changes: The PostgreSQL chart v17.0.1 uses a completely different configuration schema and secret structure than what's currently implemented in
values.yamland the Helm templates, which will cause deployment failures. - Configuration Mismatches: Parameter names have changed in the new chart versions (e.g.,
postgresqlUsername→auth.username), but these updates are not reflected in the values file. - Incomplete Migration: The minio dependency still references the old archive repository, creating inconsistency with the stated migration goal.
Comments suppressed due to low confidence (1)
deploy/kubernetes/dolphinscheduler/Chart.yaml:60
- The minio dependency still uses the legacy
archive-full-indexrepository while PostgreSQL, MySQL, and Zookeeper have been updated to use the current Bitnami repository. For consistency, minio should also be updated to usehttps://charts.bitnami.com/bitnamiif a compatible version is available in the current repository.
- name: minio
version: 11.10.13
repository: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami
condition: minio.enabled
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| # contains the full 'index.yaml'. | ||
| # See detail here: https://github.com/bitnami/charts/issues/10833 | ||
| repository: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami | ||
| version: 17.0.1 |
Copilot
AI
Nov 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating to PostgreSQL chart v17.0.1 introduces breaking changes that require updates to values.yaml and templates/_helpers.tpl:
-
Configuration parameters: The chart uses a new schema where
postgresqlUsername,postgresqlPassword, andpostgresqlDatabaseshould be changed toauth.username,auth.password, andauth.databasein values.yaml (lines 60-64). -
Secret key names: The password secret key changed from
postgresql-passwordtopassword. The template reference attemplates/_helpers.tpl:173needs to be updated accordingly. -
Service name: The default PostgreSQL service name format may have changed, potentially affecting the connection string at
templates/_helpers.tpl:154.
Without these updates, the PostgreSQL deployment will either fail or DolphinScheduler pods will be unable to connect to the database. Consider updating to an intermediate chart version first, or ensure all necessary configuration updates are included in this PR.
| version: 17.0.1 | |
| version: 12.1.5 |
| version: 11.4.11 | ||
| # Same as above. | ||
| repository: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami | ||
| version: 13.8.8 |
Copilot
AI
Nov 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Zookeeper chart version 13.8.8 may have renamed configuration parameters. Notably, fourlwCommandsWhitelist was changed to fourlwCommandsAllowlist in Bitnami Zookeeper chart v12.x and above to use more inclusive language. The values.yaml file should be checked and updated to use the correct parameter name compatible with chart version 13.8.8 to avoid configuration issues.
2884195 to
f5bd511
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
SbloodyS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E tests failed. Please check it. @zhan7236
f86cb9c to
a17d725
Compare
|
|
According to Bitnami’s official notice, after 28 Aug 2025:
@Gallardot I think it's not appropriate to directly replace all of |
Yes, it's not just about replacing the docker image. Helm charts themselves also have some configurations that need to be adapted. |
…Bitnami repository - Update PostgreSQL chart from 10.3.18 to 12.1.5 (recommended by Copilot AI review) - Update Zookeeper chart from 11.4.11 to 13.8.7 (latest stable in 13.8.x series) - Update MySQL chart from 9.4.1 to 9.23.0 (backward compatible) - Update MinIO chart from 11.10.13 to 12.13.2 (backward compatible) - Migrate all dependencies from archive-full-index to current Bitnami repository - Remove outdated comments about Bitnami repository changes This conservative update approach: - Uses PostgreSQL 12.1.5 as suggested to avoid breaking configuration schema changes - Maintains backward compatibility with existing values.yaml and templates - Migrates from legacy Bitnami registry to current repository - All dependencies verified to download successfully from new repository Addresses Copilot AI review feedback about breaking changes in newer chart versions. Closes apache#17561 Closes apache#17562 Closes apache#17563 Part of apache#17560
…cy images - Update PostgreSQL chart from 10.3.18 to 12.1.5 - Migrate config from postgresqlUsername/Password/Database to auth.username/password/database - Migrate persistence from root level to primary.persistence - Update image from bitnamilegacy/postgresql:11.11.0 to bitnami/postgresql:15.1.0-debian-11-r12 - Update Zookeeper chart from 11.4.11 to 13.8.7 - Update image from bitnamilegacy/zookeeper:3.8.4 to bitnami/zookeeper:3.9.3-debian-12-r21 - Update MySQL chart from 9.4.1 to 9.23.0 - Update image from bitnamilegacy/mysql:8.0.31 to bitnami/mysql:8.0.36-debian-12-r8 - Update MinIO chart from 11.10.13 to 12.13.2 - Update image from bitnamilegacy/minio:2022.10.29 to bitnami/minio:2023.12.23-debian-11-r3 - Update templates to use new PostgreSQL auth.* config structure - _helpers.tpl: Update database env vars references - keda-autoscaler-worker.yaml: Update PostgreSQL trigger metadata - Migrate all repositories from archive-full-index to current Bitnami repository
Auto-generated by helm-docs for the updated chart configurations.
The new Bitnami PostgreSQL chart version 12.1.5 uses 'password' as the secret key instead of 'postgresql-password'. This change aligns the DolphinScheduler Helm chart with the new Bitnami chart format. This fix resolves the E2E-K8S test failure caused by the post-install hook timing out when trying to read the PostgreSQL password from the wrong secret key.
…icy change After August 28, 2025, ZooKeeper, MySQL, MinIO and specific version tags of PostgreSQL will be removed from docker.io/bitnami and moved to bitnamilegacy. This change: - Updates postgresql image repository to bitnamilegacy/postgresql - Updates mysql image repository to bitnamilegacy/mysql - Updates minio image repository to bitnamilegacy/minio - Updates zookeeper image repository to bitnamilegacy/zookeeper The Helm chart versions remain updated to use the new configuration format (auth.username, auth.password, etc.) which are compatible with bitnamilegacy images.
f78b8b7 to
17f3f8d
Compare
…images The new Bitnami Helm charts (postgresql 12.1.5, zookeeper 13.8.7, etc.) include image signature verification that rejects non-standard images like bitnamilegacy. This causes Helm install to fail with: ERROR: Original containers have been substituted for unrecognized ones. Unrecognized images: docker.io/bitnamilegacy/zookeeper:3.9.3-debian-12-r21 Setting global.security.allowInsecureImages: true allows the use of bitnamilegacy images with the newer chart versions. Reference: bitnami/charts#30850
What is the purpose of the pull request
This PR performs a comprehensive update of the DolphinScheduler Helm charts to ensure compatibility with the new versions of Bitnami charts, as outlined in issue #17560.
The main changes include:
bitnamilegacy/*images to officialbitnami/*imagesBrief change log
Chart Version Updates:
Image Updates (migrating from bitnamilegacy to bitnami):
bitnamilegacy/postgresql:11.11.0→bitnami/postgresql:15.1.0-debian-11-r12bitnamilegacy/zookeeper:3.8.4→bitnami/zookeeper:3.9.3-debian-12-r21bitnamilegacy/mysql:8.0.31→bitnami/mysql:8.0.36-debian-12-r8bitnamilegacy/minio:2022.10.29→bitnami/minio:2023.12.23-debian-11-r3Configuration Format Updates:
postgresqlUsername/Password/Databasetoauth.username/password/databasepersistence.*toprimary.persistence.*_helpers.tplto use new PostgreSQL auth config structurekeda-autoscaler-worker.yamlto use new PostgreSQL auth configRepository Migration:
https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnamitohttps://charts.bitnami.com/bitnamiVerify this pull request
This PR has been verified by:
helm dependency update- All charts downloaded successfullyhelm template test .- Template rendering works correctlyRelated Issues
Closes #17560
Closes #17561
Closes #17562
Closes #17563
Closes #17564