Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

Dont pass account/domainid for upload sslcert in project view#893

Open
ravening wants to merge 1 commit intoapache:masterapache/cloudstack-primate:masterfrom
ravening:sslcet-projectravening/cloudstack-primate:sslcet-projectCopy head branch name to clipboard
Open

Dont pass account/domainid for upload sslcert in project view#893
ravening wants to merge 1 commit intoapache:masterapache/cloudstack-primate:masterfrom
ravening:sslcet-projectravening/cloudstack-primate:sslcet-projectCopy head branch name to clipboard

Conversation

@ravening
Copy link
Member

@ravening ravening commented Dec 8, 2020

In project view, we can upload ssl certificate either by using
projectid or accountid/domainid combination. Since we are passing
all 3 parameters, we cant upload sslcert in project view

Screenshot 2020-12-07 at 14 08 55

In project view, we can upload ssl certificate either by using
projectid or accountid/domainid combination. Since we are passing
all 3 parameters, we cant upload sslcert in project view
@yadvr yadvr requested a review from davidjumani December 9, 2020 12:00
@davidjumani
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/893 (JID-3755)

@davidjumani
Copy link
Contributor

@ravening This will make the form require the user to enter the account as well as domain which is redundant as he's already navigated to the desired account. Instead, would it be better to exclude passing the projectid if the current route contains "account" over at https://github.com/apache/cloudstack-primate/blob/master/src/utils/request.js#L83 ?

@ravening
Copy link
Member Author

@ravening This will make the form require the user to enter the account as well as domain which is redundant as he's already navigated to the desired account. Instead, would it be better to exclude passing the projectid if the current route contains "account" over at https://github.com/apache/cloudstack-primate/blob/master/src/utils/request.js#L83 ?

@davidjumani we don't need to enter anything here. If we are in project view then project id is passed else account/domain will be taken from backend code

If we pass both account and domain in project view then exception is thrown

@davidjumani
Copy link
Contributor

@ravening The account will be taken for the current user but say an admin will have to pass the account and domain while adding a certificate for another account, after having navigated to that account

@yadvr
Copy link
Member

yadvr commented Jan 14, 2021

Ping @ravening any update on this?

@weizhouapache
Copy link

@ravening @rhtyd @davidjumani
can we do like this ?
(1) in project view, ssl cert will be uploaded to project account, no matter what current account is.
otherwise there is no way to upload ssl cert to a project.
(2) in normal view, ssl cert will be uploaded to the current account on web page.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.