Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

Use scaleVirtualMachine API instead of changeServiceForVirtualMachine #818

Merged
yadvr merged 1 commit into from
Oct 30, 2020
Merged

Use scaleVirtualMachine API instead of changeServiceForVirtualMachine #818

yadvr merged 1 commit into from
Oct 30, 2020

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Oct 23, 2020

Align with Legacy UI and call scaleVirtualMachine API when attempting scaling

@Pearl1594
Copy link
Contributor Author

Pearl1594 commented Oct 23, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 23, 2020

@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Oct 23, 2020

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/818 (JID-3613)

@yadvr yadvr requested review from davidjumani and shwstppr October 23, 2020 11:46
@yadvr yadvr added this to the 1.0-GA milestone Oct 23, 2020
@GabrielBrascher
Copy link
Member

GabrielBrascher commented Oct 27, 2020

For reference, here follows some CloudStack issues raised due to changeServiceForVIrtualMachine API command problems:

@davidjumani
Copy link
Contributor

davidjumani commented Oct 27, 2020 •
edited
Loading

Thanks @GabrielBrascher There were a few other reasons we went with changeServiceForVirtualMachine when the VM is stopped which I can't recall atm

@yadvr
Copy link
Member

yadvr commented Oct 28, 2020

@davidjumani @Pearl1594 @shwstppr can you share reasons for the change - thanks. I see legacy UI uses the scale API, is that it?

shwstppr
shwstppr approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Consistent with legacy UI. As per apache/cloudstack#4125 changeServiceForVirtualMachine seems to be having issues and scaleVirtualMachine handles both running and stopped VMs.
@davidjumani if there is any corner case failing we can handle in backend

@Pearl1594
Copy link
Contributor Author

Pearl1594 commented Oct 28, 2020

@rhtyd

  1. changeServiceForVirtualMachine isn't used by the legacy UI either when we attempt scaling
  2. scaleVirtualMachine does what changeServiceForVirtualMachine does - i.e., updates the service offering, and in addition to that, it also performs volume resizing.

GabrielBrascher
GabrielBrascher approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

CloudStack UI currently also does not use the changeServiceForVIrtualMachine. Additionally, there are a couple of open issues regarding changeServiceForVIrtualMachine API command problems:

@yadvr yadvr merged commit 77a59f6 into apache:master Oct 30, 2020
@Pearl1594 Pearl1594 mentioned this pull request Oct 30, 2020
Merged
5 tasks
Pearl1594 added a commit to shapeblue/cloudstack-primate that referenced this pull request Nov 11, 2020
@Pearl1594
Use scaleVirtualMachine API instead of changeServiceForVirtualMachine (…
eb423ab 
…apache#818)

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
@GabrielBrascher GabrielBrascher mentioned this pull request Nov 18, 2020
Closed
weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
@Pearl1594 @ustcweizhou
Use scaleVirtualMachine API instead of changeServiceForVirtualMachine (…
fb4290f 
…#818)

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidjumani davidjumani Awaiting requested review from davidjumani

2 more reviewers

@shwstppr shwstppr shwstppr approved these changes

@GabrielBrascher GabrielBrascher GabrielBrascher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0-GA

Development

Successfully merging this pull request may close these issues.

6 participants

@Pearl1594 @blueorangutan @GabrielBrascher @davidjumani @yadvr @shwstppr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.