Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

vApps frontend support#550

Merged
yadvr merged 23 commits intoapache:masterapache/cloudstack-primate:masterfrom
shapeblue:vappsproperty-refactorshapeblue/cloudstack-primate:vappsproperty-refactorCopy head branch name to clipboard
Aug 17, 2020
Merged

vApps frontend support#550
yadvr merged 23 commits intoapache:masterapache/cloudstack-primate:masterfrom
shapeblue:vappsproperty-refactorshapeblue/cloudstack-primate:vappsproperty-refactorCopy head branch name to clipboard

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Jul 21, 2020

Changes in backend

@shwstppr
changes for backend refactor
490e04e 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Jul 21, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 21, 2020

@shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 21, 2020

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/550 (JID-2501)

shwstppr added 11 commits July 23, 2020 11:30
@shwstppr
revert properties changes
0a6ee3a 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
changes for nic-network map
f283f91 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
sort based on InstanceID
577bf9b 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
temp - don't send iptonwtwork param
969b8fc 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
use automaticAllocation
dd06de0 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
ignore automaticAllocation
84e5f58 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
display template configurations for compute offering
e75903c 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
show normal offerings and separate configuration input
0d35725 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
fixes
5350119 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
fix custom offering params visibility
42cc599 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
fix for fixed offerings
6b49438 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Aug 3, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Aug 3, 2020

@DaanHoogland a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

shwstppr added 3 commits August 4, 2020 10:03
@shwstppr
fix
6c72acf 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Merge branch 'master' into vappsproperty-refactor
f545bdf 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
check fix
5e96214 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@yadvr yadvr added this to the 1.0-GA milestone Aug 4, 2020
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Aug 5, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2020

@DaanHoogland a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2020

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/550 (JID-2892)

@nvazquez nvazquez mentioned this pull request Aug 6, 2020
Closed
5 tasks
@nvazquez
Copy link
Contributor

nvazquez commented Aug 7, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Aug 7, 2020

@nvazquez a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Aug 7, 2020

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/550 (JID-2935)

@yadvr
Copy link
Member

yadvr commented Aug 12, 2020

@shwstppr @nvazquez is this ready for review/merging or are we expecting more changes?

@shwstppr
Copy link
Contributor Author

shwstppr commented Aug 12, 2020

changes for licenses remaining @rhtyd

shwstppr and others added 2 commits August 12, 2020 17:57
@shwstppr
show and verify licenses
1c0102e 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@nvazquez
Fix license display
f024f87
@shwstppr shwstppr marked this pull request as ready for review August 13, 2020 06:26
@shwstppr shwstppr marked this pull request as draft August 13, 2020 11:36
@yadvr yadvr changed the title vapps backend refactor vApps frontend support Aug 14, 2020
@yadvr
Copy link
Member

yadvr commented Aug 14, 2020

@shwstppr @nvazquez is this ready for review/testing now?
@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Aug 14, 2020

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Aug 14, 2020

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/550 (JID-3134)

@shwstppr shwstppr marked this pull request as ready for review August 14, 2020 09:13
@shwstppr
Copy link
Contributor Author

shwstppr commented Aug 14, 2020

@rhtyd yes, please review

@yadvr yadvr requested review from nvazquez and yadvr August 14, 2020 10:56
nvazquez
nvazquez approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on testing and fixing some issues. @rhtyd maybe good to keep it open until testing is finished, in case of any issues?

yadvr
yadvr approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested against a non-vapp feature backend (primate-qa server), was able to deploy VM.

@yadvr yadvr merged commit b690814 into apache:master Aug 17, 2020
weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
@shwstppr @nvazquez @ustcweizhou
compute: vApps frontend support (#550)
3893c02 
Support for vApp VM deployment for VMware
Backend PR - apache/cloudstack#4250

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: nvazquez <nicovazquez90@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@yadvr yadvr yadvr approved these changes

@nvazquez nvazquez nvazquez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0-GA

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr @blueorangutan @DaanHoogland @nvazquez @yadvr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.