Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Modify State Changing Requests to Utilize POST Request #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
Loading
from

Conversation

kevin-lii
Copy link

Currently State Changing Request utilize GET request but this is a potential security vulnerability since attackers may be able to intercept and extract the query parameters of GET requests. Utilizing POST requests will help mitigate this security vulnerability since the parameters of the POST body will be encrypted in transport.

generate/generate.go Outdated Show resolved Hide resolved
cloudstack/AccountService.go Outdated Show resolved Hide resolved
cloudstack/CloudianService.go Outdated Show resolved Hide resolved
cloudstack/ManagementService.go Outdated Show resolved Hide resolved
cloudstack/QuotaService.go Outdated Show resolved Hide resolved
cloudstack/QuotaService.go Outdated Show resolved Hide resolved
cloudstack/QuotaService.go Outdated Show resolved Hide resolved
cloudstack/QuotaService.go Outdated Show resolved Hide resolved
cloudstack/QuotaService.go Outdated Show resolved Hide resolved
Copy link

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland
Copy link
Contributor

@kevin-lii , can you rebase on latest to have the post requests tested against a simulator running in a container, please? (see #111 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.