Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update docs for 4.18.2.0 #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

JoaoJandre
Copy link
Contributor

Update docs for 4.18.2.0

@JoaoJandre
Copy link
Contributor Author

@rohityadavcloud @weizhouapache @shwstppr @nvazquez could you please review?

@JoaoJandre
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@JoaoJandre a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/393. (QA-JID 224)

source/releasenotes/about.rst Outdated Show resolved Hide resolved
source/releasenotes/changes.rst Outdated Show resolved Hide resolved
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - minor concerns raised, good to go. @JoaoJandre let me know if you have access of readthedocs, https://readthedocs.org/accounts/login/ - if not create an account and share your username. Alternatively, once this PR and git tag is ready we can hit publish for you too. cc @DaanHoogland @weizhouapache

@JoaoJandre
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@JoaoJandre a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/393. (QA-JID 225)

@JoaoJandre
Copy link
Contributor Author

LGTM - minor concerns raised, good to go. @JoaoJandre let me know if you have access of readthedocs, https://readthedocs.org/accounts/login/ - if not create an account and share your username. Alternatively, once this PR and git tag is ready we can hit publish for you too. cc @DaanHoogland @weizhouapache

@rohityadavcloud I don't have admin access to the readthedocs, could you give me access? my username is: JoaoJandre.

@rohityadavcloud
Copy link
Member

@JoaoJandre done, I've added you as a maintainer/admin on https://readthedocs.org/projects/cloudstack-documentation/ you should get receive an invite. After you log in, the steps to publishing a git tag is easy; (a) merge this PR and create a git push on this repo, (b) go to https://readthedocs.org/projects/cloudstack-documentation/ and under version or admin enable the version (4.18.2.0) and check (c) it should start the build and pass successfully, (d) edit the release/tag and make it public, that's it.

@JoaoJandre JoaoJandre merged commit 15e9f04 into apache:4.18 Apr 18, 2024
@rohityadavcloud
Copy link
Member

Cheers @JoaoJandre I see the tag and docs are live now, the website is updated too. I think only thing remaining is the ML announcement for you to draft/send.

@JoaoJandre
Copy link
Contributor Author

Cheers @JoaoJandre I see the tag and docs are live now, the website is updated too. I think only thing remaining is the ML announcement for you to draft/send.

@rohityadavcloud Thanks, the announcement is already drafted, only waiting for the reviews: https://lists.apache.org/thread/hz3d737ok1s6ydnky54c4clsjddlkpfg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.