-
Notifications
You must be signed in to change notification settings - Fork 115
Update docs for 4.18.2.0 #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rohityadavcloud @weizhouapache @shwstppr @nvazquez could you please review? |
@blueorangutan docbuild |
@JoaoJandre a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/393. (QA-JID 224) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - minor concerns raised, good to go. @JoaoJandre let me know if you have access of readthedocs, https://readthedocs.org/accounts/login/ - if not create an account and share your username. Alternatively, once this PR and git tag is ready we can hit publish for you too. cc @DaanHoogland @weizhouapache
@blueorangutan docbuild |
@JoaoJandre a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/393. (QA-JID 225) |
@rohityadavcloud I don't have admin access to the readthedocs, could you give me access? my username is: |
@JoaoJandre done, I've added you as a maintainer/admin on https://readthedocs.org/projects/cloudstack-documentation/ you should get receive an invite. After you log in, the steps to publishing a git tag is easy; (a) merge this PR and create a git push on this repo, (b) go to https://readthedocs.org/projects/cloudstack-documentation/ and under version or admin enable the version (4.18.2.0) and check (c) it should start the build and pass successfully, (d) edit the release/tag and make it public, that's it. |
Cheers @JoaoJandre I see the tag and docs are live now, the website is updated too. I think only thing remaining is the ML announcement for you to draft/send. |
@rohityadavcloud Thanks, the announcement is already drafted, only waiting for the reviews: https://lists.apache.org/thread/hz3d737ok1s6ydnky54c4clsjddlkpfg |
Update docs for 4.18.2.0