Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

metrics notes#294

Merged
DaanHoogland merged 9 commits intoapache:mainapache/cloudstack-documentation:mainfrom
shapeblue:resource-metrics-notesshapeblue/cloudstack-documentation:resource-metrics-notesCopy head branch name to clipboard
Jan 30, 2023
Merged

metrics notes#294
DaanHoogland merged 9 commits intoapache:mainapache/cloudstack-documentation:mainfrom
shapeblue:resource-metrics-notesshapeblue/cloudstack-documentation:resource-metrics-notesCopy head branch name to clipboard

Conversation

@shwstppr
Copy link
Contributor

Notes about VM and VM disk metrics and the improvements added in apache/cloudstack#6803

Notes about VM and VM disk metrics and the improvements added in apache/cloudstack#6803

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/294. (QA-JID 10)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@yadvr
Copy link
Member

yadvr commented Dec 16, 2022

@blueorangutan docbuild

@blueorangutan
Copy link

@rohityadavcloud a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/294. (QA-JID 17)

@DaanHoogland
Copy link
Contributor

@shwstppr the images do not show in the paragraph they are intended for (or am I looking with crooked eyes/false expectations?)
see the paragraphs

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

Thanks @DaanHoogland for pointing it out. Made the changes
@blueorangutan docbuild

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/294. (QA-JID 20)

@andrijapanicsb
Copy link
Contributor

@shwstppr we fixed graphs in the meantime - so these need to be updated here please (new graphs on the volume level)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/294. (QA-JID 31)

@DaanHoogland DaanHoogland added this to the 4.18 milestone Jan 26, 2023
@shwstppr
Copy link
Contributor Author

@andrijapanicsb @borisstoyanov are you good on this?

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content looks good, some style suggestion

source/adminguide/virtual_machines.rst Outdated Show resolved Hide resolved
source/adminguide/virtual_machines.rst Outdated Show resolved Hide resolved
source/adminguide/virtual_machines.rst Outdated Show resolved Hide resolved
source/adminguide/virtual_machines.rst Outdated Show resolved Hide resolved
source/adminguide/virtual_machines.rst Outdated Show resolved Hide resolved
shwstppr and others added 4 commits January 30, 2023 14:39
Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
@shwstppr shwstppr marked this pull request as ready for review January 30, 2023 09:10
@shwstppr
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/294. (QA-JID 32)

Copy link
Contributor

@andrijapanicsb andrijapanicsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland DaanHoogland merged commit 930f375 into apache:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.