Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

enum name changed for logger update reverted#9922

Merged
JoaoJandre merged 1 commit intoapache:mainapache/cloudstack:mainfrom
shapeblue:poolTypeNameErrorshapeblue/cloudstack:poolTypeNameErrorCopy head branch name to clipboard
Nov 14, 2024
Merged

enum name changed for logger update reverted#9922
JoaoJandre merged 1 commit intoapache:mainapache/cloudstack:mainfrom
shapeblue:poolTypeNameErrorshapeblue/cloudstack:poolTypeNameErrorCopy head branch name to clipboard

Conversation

@DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Nov 13, 2024 •
edited
Loading

Description

This PR fixes an unintended name change on an enum member for pooltype

Fixes: #9915

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland DaanHoogland added this to the 4.20.0 milestone Nov 13, 2024
@codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.04%. Comparing base (f7b7339) to head (044553a).
Report is 6 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (f7b7339) and HEAD (044553a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f7b7339) HEAD (044553a)
unittests 1 0
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #9922       +/-   ##
============================================
- Coverage     15.80%   4.04%   -11.77%     
============================================
  Files          5627     392     -5235     
  Lines        492294   32170   -460124     
  Branches      62198    5677    -56521     
============================================
- Hits          77824    1301    -76523     
+ Misses       405946   30721   -375225     
+ Partials       8524     148     -8376
Flag Coverage Δ
uitests 4.04% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

slavkap
slavkap approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@slavkap slavkap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@JoaoJandre
Copy link
Contributor

JoaoJandre commented Nov 13, 2024

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Nov 13, 2024

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Nov 13, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11558

@JoaoJandre
Copy link
Contributor

JoaoJandre commented Nov 13, 2024

@DaanHoogland @sureshanaparti could we run the CI here?

@DaanHoogland
Copy link
Contributor Author

DaanHoogland commented Nov 13, 2024

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Nov 13, 2024

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@slavkap slavkap mentioned this pull request Nov 14, 2024
Closed
@blueorangutan
Copy link

blueorangutan commented Nov 14, 2024

[SF] Trillian test result (tid-11776)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55091 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9922-t11776-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_secure_vm_migration Error 398.00 test_vm_life_cycle.py

weizhouapache
weizhouapache approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@JoaoJandre JoaoJandre merged commit b75742d into apache:main Nov 14, 2024
@DaanHoogland DaanHoogland deleted the poolTypeNameError branch November 14, 2024 14:43
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 20, 2024
@DaanHoogland @dhslove
enum name changed for logger update reverted (apache#9922)
01cb44d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GutoVeronezi GutoVeronezi GutoVeronezi approved these changes

@JoaoJandre JoaoJandre JoaoJandre approved these changes

@slavkap slavkap slavkap approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:kvm Severity:BLOCKER type:cleanup type:regression

Projects

None yet

Milestone

4.20.0

Development

Successfully merging this pull request may close these issues.

Error when using CLVM in KVM Hypervisor

6 participants

@DaanHoogland @JoaoJandre @blueorangutan @GutoVeronezi @slavkap @weizhouapache
Morty Proxy This is a proxified and sanitized view of the page, visit original site.