Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

server: fix vm_stats records are not removed if batchsize is 0#9818

Merged
yadvr merged 1 commit intoapache:mainapache/cloudstack:mainfrom
weizhouapache:4.20-fix-vm_stats-cleanupweizhouapache/cloudstack:4.20-fix-vm_stats-cleanupCopy head branch name to clipboard
Oct 18, 2024
Merged

server: fix vm_stats records are not removed if batchsize is 0#9818
yadvr merged 1 commit intoapache:mainapache/cloudstack:mainfrom
weizhouapache:4.20-fix-vm_stats-cleanupweizhouapache/cloudstack:4.20-fix-vm_stats-cleanupCopy head branch name to clipboard

Conversation

@weizhouapache
Copy link
Contributor

@weizhouapache weizhouapache commented Oct 17, 2024

Description

Prior to this change

2024-10-17T10:32:55,455 DEBUG [c.c.v.d.VmStatsDaoImpl] (StatsCollector-5:[ctx-ec4b3698]) (logid:708dd27c) Starting to remove all vm_stats rows older than [Wed Oct 16 22:32:55 UTC 2024].
2024-10-17T10:32:55,456 INFO  [c.c.v.d.VmStatsDaoImpl] (StatsCollector-5:[ctx-ec4b3698]) (logid:708dd27c) Removed a total of [0] vm_stats rows older than [Wed Oct 16 22:32:55 UTC 2024].

With this change

2024-10-17T10:41:33,315 DEBUG [c.c.v.d.VmStatsDaoImpl] (StatsCollector-5:[ctx-dd8d7e09]) (logid:338dd659) Starting to remove all vm_stats rows older than [Wed Oct 16 22:41:33 UTC 2024].
2024-10-17T10:43:03,184 INFO  [c.c.v.d.VmStatsDaoImpl] (StatsCollector-5:[ctx-dd8d7e09]) (logid:338dd659) Removed a total of [1661329] vm_stats rows older than [Wed Oct 16 22:41:33 UTC 2024].

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.20.0.0 milestone Oct 17, 2024
@codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.78%. Comparing base (20901c7) to head (9a1bdaf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...java/com/cloud/storage/dao/VolumeStatsDaoImpl.java 0.00% 1 Missing ⚠️
...src/main/java/com/cloud/vm/dao/VmStatsDaoImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #9818   +/-   ##
=========================================
  Coverage     15.78%   15.78%           
- Complexity    12564    12565    +1     
=========================================
  Files          5627     5627           
  Lines        492266   492250   -16     
  Branches      63860    63795   -65     
=========================================
+ Hits          77707    77710    +3     
+ Misses       406084   406066   -18     
+ Partials       8475     8474    -1
Flag Coverage Δ
uitests 4.04% <ø> (ø)
unittests 16.60% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yadvr
yadvr approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM didn't test it

@weizhouapache weizhouapache marked this pull request as ready for review October 17, 2024 11:35
@weizhouapache
Copy link
Contributor Author

weizhouapache commented Oct 17, 2024

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 17, 2024

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Oct 17, 2024

related to
@JoaoJandre 's PR #8740
@shwstppr 's PR #8999
@vishesh92 's merge commit 3923f80#diff-1ccbb9294e1b4e876df4f865c95f8f302ccea7a2ce6cfe574d0efa76e8f88868R1238

JoaoJandre
JoaoJandre approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@JoaoJandre JoaoJandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishesh92
Copy link
Member

vishesh92 commented Oct 17, 2024

@weizhouapache We need this change in 4.19 since the PRs you mentioned are part of 4.19 branch.

shwstppr
shwstppr approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

sureshanaparti
sureshanaparti approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Oct 17, 2024

@weizhouapache We need this change in 4.19 since the PRs you mentioned are part of 4.19 branch.

4.19 has similar change introduced in #8740 , it works

@blueorangutan
Copy link

blueorangutan commented Oct 17, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11379

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Oct 17, 2024

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Oct 17, 2024

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Oct 18, 2024

[SF] Trillian test result (tid-11682)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60826 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9818-t11682-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_create_pvlan_network Error 0.10 test_pvlan.py
test_disable_oobm_ha_state_ineligible Error 322.16 test_hostha_kvm.py
test_hostha_configure_default_driver Error 112.52 test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected Error 553.63 test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance Error 548.49 test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance Error 548.49 test_hostha_kvm.py
test_hostha_kvm_host_degraded Error 41.62 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 37.88 test_hostha_kvm.py
test_hostha_kvm_host_recovering Error 35.38 test_hostha_kvm.py
test_remove_ha_provider_not_possible Error 35.32 test_hostha_kvm.py

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Oct 18, 2024

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Oct 18, 2024

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@yadvr
Copy link
Member

yadvr commented Oct 18, 2024

host_ha test failures are intermittent in nature. Let's merge this for sake of time & kick test matrix on the health check PR cc @JoaoJandre

@yadvr yadvr merged commit 019f2c6 into apache:main Oct 18, 2024
@blueorangutan
Copy link

blueorangutan commented Oct 18, 2024

[SF] Trillian test result (tid-11686)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51586 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9818-t11686-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 24, 2024
@weizhouapache @dhslove
server: fix vm_stats records are not removed if batchsize is 0 (apach…
f44fbb1 
…e#9818)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@shwstppr shwstppr shwstppr approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@JoaoJandre JoaoJandre JoaoJandre approved these changes

@vishesh92 vishesh92 Awaiting requested review from vishesh92

Assignees

No one assigned

Labels

component:database component:storage Severity:BLOCKER

Projects

None yet

Milestone

4.20.0

Development

Successfully merging this pull request may close these issues.

7 participants

@weizhouapache @blueorangutan @vishesh92 @yadvr @shwstppr @sureshanaparti @JoaoJandre
Morty Proxy This is a proxified and sanitized view of the page, visit original site.