Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix bugs on last step on Wizard zone and Adv Search box#912

Closed
milamberspace wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
milamberspace:BugZoneWizardAndAdvSearchPopupmilamberspace/cloudstack:BugZoneWizardAndAdvSearchPopupCopy head branch name to clipboard
Closed

Fix bugs on last step on Wizard zone and Adv Search box#912
milamberspace wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
milamberspace:BugZoneWizardAndAdvSearchPopupmilamberspace/cloudstack:BugZoneWizardAndAdvSearchPopupCopy head branch name to clipboard

Conversation

@milamberspace
Copy link
Contributor

Javascript error: Uncaught ReferenceError: _ is not defined
Missing 'l' (to call the _l() function)

Bug introduce by me (#712)

For the zone wizard, the Next button isn't replace by Finish button and the steps don't display in the box.
For the Adv Search box, the label of search button is "submit" instead of "Search" (in en_US localization)

Javascript error: Uncaught ReferenceError: _ is not defined
=> Missing 'l' (to call the _l() function)

Bug introduce by me (apache#712)

For the zone wizard, the Next button isn't replace by Finish button and the steps don't display in the box.
For the Adv Search box, the label of search button is "submit" instead of "Search" (in en_US localization)
=
@milamberspace
Copy link
Contributor Author

@remibergsma
Probably this is a 'minor' blocker bug for the 4.6 release.

@remibergsma
Copy link
Contributor

@milamberspace Thanks, this we should include indeed. Will try to test in the coming days.

@sebgoa
Copy link
Member

sebgoa commented Oct 5, 2015

@milamberspace @remibergsma there is a duplicate at #906

@milamberspace
Copy link
Contributor Author

@Runseb Good catch!
Thanks @nitin-maharana to fix part of this bugs.
@remibergsma my PR add a bug on Adv search label.

@DaanHoogland
Copy link
Contributor

I tried to run the wizard with this patch applied but the wizard doesn't show 'finished' nor does it finish after pressing 'next' for a final time. I shows a blank screen and then loops back to the beginning of the wizard.

@milamberspace
Copy link
Contributor Author

@DaanHoogland you need to double-check that the old zoneWizard.js file is changed on you browser (clean cache) and on the tomcat installation (if not a new installation) in work/temp dir. I have a lot of problem to test that because even I clean my browser cache, the tomcat service continue to serve the old zoneWizard.js without the L in the _l() function. Finally I made a full clean installation of CS to validate my fixes.

@milamberspace
Copy link
Contributor Author

Closed. New PR #915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.