Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: clean magic value, and update if-else to switch #8848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sureshanaparti merged 4 commits into from
Jan 28, 2026
Merged

fix: clean magic value, and update if-else to switch #8848

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8000d5
fix: clean magic value, and update if-else to switch
Mar 29, 2024
78fac07
fix: return the (String args[])
Mar 29, 2024
82362a0
Merge branch '4.22' into fix/service_client
sureshanaparti Jan 27, 2026
d29fda7
review
sureshanaparti Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions 34 services/console-proxy/rdpconsole/src/main/java/common/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@ private void help() {
public void runClient(String[] args) {

try {

Protocol protocol = parseOptions(args);
if (protocol == Protocol.NONE)
return;
Expand Down Expand Up @@ -299,21 +298,28 @@ private Element setMainElementAndAddressBasedOnProtocol(Protocol protocol, SSLSt

private Protocol parseOptions(String[] args) {
String protocolName = (args.length > 0) ? args[0] : "";
Protocol protocol = Protocol.NONE;
Protocol protocol;
sureshanaparti marked this conversation as resolved.
Show resolved Hide resolved

Option[] options;
if (protocolName.equals("vnc")) {
protocol = Protocol.VNC;
options = join(commonOptions, vncOptions);
} else if (protocolName.equals("rdp")) {
protocol = Protocol.RDP;
options = join(commonOptions, rdpOptions);
} else if (protocolName.equals("hyperv")) {
protocol = Protocol.HYPERV;
options = join(commonOptions, hyperVOptions);
} else {
help();
return Protocol.NONE;
try {
protocol = Protocol.valueOf(protocolName);
} catch (IllegalArgumentException e) {
protocol = Protocol.NONE;
}

switch (protocol) {
case VNC:
options = join(commonOptions, vncOptions);
break;
case RDP:
options = join(commonOptions, rdpOptions);
break;
case HYPERV:
options = join(commonOptions, hyperVOptions);
break;
default:
help();
return Protocol.NONE;
}

// Parse all options for given protocol
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.